Remove Redundant Cleanup Step in Snapshot Failure #54395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ever since we don't write any data to the repo during snapshot initialization, the `snapshotCreated` flag has become obsolete. If we run into any exception during snapshot init we should not redundantly finalize an empty snapshot in the reopsitory.
original-brownbear
added
>non-issue
:Distributed Coordination/Snapshot/Restore
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
|
Thanks Yannick! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Mar 30, 2020
Similar to elastic#54395 we know that a snapshot in INIT state has not written anything to the repository yet. If we see one from a master failover, there is no point in moving it to ABORTED before removing it from the cluster state in a subsequent CS update. Instead, we can simply remove its job from the CS the first time we see it on master failover and be done with it.
original-brownbear
added a commit
that referenced
this pull request
Mar 30, 2020
…#54420) * Remove Redundant Cluster State during Snapshot INIT + Master Failover Similar to #54395 we know that a snapshot in INIT state has not written anything to the repository yet. If we see one from a master failover, there is no point in moving it to ABORTED before removing it from the cluster state in a subsequent CS update. Instead, we can simply remove its job from the CS the first time we see it on master failover and be done with it.
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Apr 15, 2020
…elastic#54420) * Remove Redundant Cluster State during Snapshot INIT + Master Failover Similar to elastic#54395 we know that a snapshot in INIT state has not written anything to the repository yet. If we see one from a master failover, there is no point in moving it to ABORTED before removing it from the cluster state in a subsequent CS update. Instead, we can simply remove its job from the CS the first time we see it on master failover and be done with it.
original-brownbear
added a commit
that referenced
this pull request
Apr 15, 2020
…#54420) (#55208) * Remove Redundant Cluster State during Snapshot INIT + Master Failover (#54420) Similar to #54395 we know that a snapshot in INIT state has not written anything to the repository yet. If we see one from a master failover, there is no point in moving it to ABORTED before removing it from the cluster state in a subsequent CS update. Instead, we can simply remove its job from the CS the first time we see it on master failover and be done with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ever since we don't write any data to the repo during
snapshot initialization (#45689), the
snapshotCreatedflag has become obsolete.If we run into any exception during snapshot init we should not redundantly
finalize an empty snapshot in the repository.
Note: in the backport to 7.x we can't fully remove this logic because we still have to support rolling upgrades mixed with older versions that write some data to the repository during snapshot init but we can clean up the logic there as well to not run finalization if nothing was written to the repository yet (the way the flag was intended to function initially anyway).