Fix empty_value handling in CsvProcessor #55649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to bug in `CsvProcessor.Factory` it was impossible to specify `empty_value`. This change fixes that and adds relevant test. Closes elastic#55643
probakowski
added
>bug
:Data Management/Ingest Node
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Ingest) |
martijnvg
approved these changes
Apr 29, 2020
Member
martijnvg
left a comment
martijnvg
left a comment
There was a problem hiding this comment.
LGTM 👍
Thanks for fixing @probakowski!
probakowski
added a commit
to probakowski/elasticsearch
that referenced
this pull request
Apr 29, 2020
* Fix empty_value handling in CsvProcessor Due to bug in `CsvProcessor.Factory` it was impossible to specify `empty_value`. This change fixes that and adds relevant test. Closes elastic#55643 * assert changed
probakowski
added a commit
to probakowski/elasticsearch
that referenced
this pull request
Apr 29, 2020
* Fix empty_value handling in CsvProcessor Due to bug in `CsvProcessor.Factory` it was impossible to specify `empty_value`. This change fixes that and adds relevant test. Closes elastic#55643 * assert changed
probakowski
added a commit
that referenced
this pull request
Apr 29, 2020
probakowski
added a commit
that referenced
this pull request
Apr 29, 2020
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to bug in
CsvProcessor.Factoryit was impossible to specifyempty_value.This change fixes that and adds relevant test.
Closes #55643