-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update logstash_admin role for system indices #63368
Merged
gwbrown
merged 6 commits into
elastic:master
from
williamrandolph:logstash-sys-index-security-role
Oct 7, 2020
Merged
Update logstash_admin role for system indices #63368
gwbrown
merged 6 commits into
elastic:master
from
williamrandolph:logstash-sys-index-security-role
Oct 7, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwbrown
approved these changes
Oct 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
gwbrown
changed the title
WIP: Update logstash_admin role for system indices
Update logstash_admin role for system indices
Oct 7, 2020
gwbrown
added
:Core/Infra/Core
Core issues without another label
>non-issue
v7.10.0
v8.0.0
labels
Oct 7, 2020
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
gwbrown
added a commit
that referenced
this pull request
Oct 7, 2020
This PR updates the `logstash_admin` role to include the recently-added Logstash Pipeline Management APIs, as well as access to the `.logstash*` index pattern. Co-authored-by: William Brafford <williamrandolphbrafford@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Core/Infra/Core
Core issues without another label
>non-issue
Team:Core/Infra
Meta label for core/infra team
v7.10.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a Logstash xpack plugin that can access system indices in #53350, but we didn't hook it into security roles. This PR will update the current
logstash_admin
role so that the role allows both the old direct access to.logstash-*
indexes as well as the use of the new plugin.Closes #63133