Simplify Snapshot ITs Further #63655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing some more duplication and redundant logic.
original-brownbear
added
>test
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
elasticmachine
added
the
Team:Distributed (Obsolete)
| protected void awaitMasterFinishRepoOperations() throws Exception { | ||
| logger.info("--> waiting for master to finish all repo operations on its SNAPSHOT pool"); | ||
| final ThreadPool masterThreadPool = internalCluster().getMasterNodeInstance(ThreadPool.class); | ||
| final ThreadPool masterThreadPool = internalCluster().getCurrentMasterNodeInstance(ThreadPool.class); |
Contributor
Author
There was a problem hiding this comment.
This actually fixes a bug, we just didn't see the bug in practice yet because we only used this method in tests with a single master node ...
Member
There was a problem hiding this comment.
Yeah, I noticed similar issue in DiskThresholdDeciderIT. getMasterNodeInstance() is trappy and should be renamed.
tlrx
approved these changes
Oct 14, 2020
Contributor
Author
|
Thanks Tanguy! |
original-brownbear
added a commit
that referenced
this pull request
Oct 26, 2020
* Removing some more duplication and redundant logic. * Aligning all timeouts to 30s (60s or even 10 minute timeouts should be unnecessary, if they aren't we should figure out why) * Remove some usage of `actionGet()` in tests (it's just evil to suppress the stack-trace)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actionGet()in tests (it's just evil to suppress the stack-trace)