Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor DRYing up of attachment processor tests #65975

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Minor DRYing up of attachment processor tests #65975

merged 1 commit into from
Dec 8, 2020

Conversation

danhermann
Copy link
Contributor

Relates to #64389

@danhermann danhermann added >non-issue :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >refactoring v8.0.0 v7.11.0 labels Dec 7, 2020
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Dec 7, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

martijnvg
martijnvg approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danhermann
Copy link
Contributor Author

Thank you, @martijnvg!

@danhermann danhermann merged commit 149f1f9 into elastic:master Dec 8, 2020
@danhermann danhermann deleted the dry_up_attachment_tests branch December 8, 2020 17:38
danhermann added a commit to danhermann/elasticsearch that referenced this pull request Feb 1, 2021
@danhermann
Minor DRYing up of attachment processor tests (elastic#65975)
6f2c881
@danhermann danhermann mentioned this pull request Feb 1, 2021
Merged
@danhermann danhermann added v7.12.0 and removed v7.11.0 labels Feb 1, 2021
danhermann added a commit that referenced this pull request Feb 1, 2021
@danhermann
Minor DRYing up of attachment processor tests (#65975) (#68294)
8a0dddd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martijnvg martijnvg martijnvg approved these changes

Assignees
No one assigned
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >non-issue >refactoring Team:Data Management Meta label for data/management team v7.12.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danhermann @elasticmachine @martijnvg @jakelandis