System indices auto-create for searchable-snapshots #66940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport of elastic#66276. Part of elastic#61656. Use the system indices auto-creation infrastructure for the searchable snapshots plugin.
pugnascotia
added
:Distributed Indexing/Distributed
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
tlrx
approved these changes
Jan 6, 2021
| ); | ||
| @Override | ||
| public void onFailure(Exception e) { | ||
| logger.debug(new ParameterizedMessage("failure in cache fill: [{}]", request.id()), e); |
There was a problem hiding this comment.
We can use debug(Supplier<?> msgSupplier, Throwable t)
tlrx
reviewed
Jan 6, 2021
| }); | ||
| }); | ||
| } catch (Exception e) { | ||
| logger.warn(new ParameterizedMessage("cache fill failure: [{}]", CachedBlob.generateId(repository, name, path, offset)), e); |
There was a problem hiding this comment.
We should use warn(Supplier<?> msgSupplier, Throwable t)
|
@tlrx thanks for the review. I won't change those logging methods as they are the same in |
|
Thanks. I think we can change them in master too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #66276.
Part of #61656. Use the system indices auto-creation infrastructure
for the searchable snapshots plugin.