Exclude partially cached .cfs file from SearchableSnapshotDirectoryStatsTests #70006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>test
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
Thanks Yannick |
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Mar 5, 2021
…atsTests (elastic#70006) Since elastic#69861 CFS files read from FrozenIndexInput create dedicated frozen shared cache files when they are sliced. This does not play well with some tests that use the randomReadAndSlice to read files: this method can create overlapping slice/clone reads operations which makes it difficult to assert anything about CFS files with partial cache. This commit prevent the tests to generate a .cfs file name when the partial cache is randomly picked up. As a follow up we should rework those test to make them more realistic with the new behavior. Closes elastic#70000
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Mar 5, 2021
…atsTests (elastic#70006) Since elastic#69861 CFS files read from FrozenIndexInput create dedicated frozen shared cache files when they are sliced. This does not play well with some tests that use the randomReadAndSlice to read files: this method can create overlapping slice/clone reads operations which makes it difficult to assert anything about CFS files with partial cache. This commit prevent the tests to generate a .cfs file name when the partial cache is randomly picked up. As a follow up we should rework those test to make them more realistic with the new behavior. Closes elastic#70000
tlrx
added a commit
that referenced
this pull request
Mar 5, 2021
…atsTests (#70006) (#70019) Since #69861 CFS files read from FrozenIndexInput create dedicated frozen shared cache files when they are sliced. This does not play well with some tests that use the randomReadAndSlice to read files: this method can create overlapping slice/clone reads operations which makes it difficult to assert anything about CFS files with partial cache. This commit prevent the tests to generate a .cfs file name when the partial cache is randomly picked up. As a follow up we should rework those test to make them more realistic with the new behavior. Closes #70000
tlrx
added a commit
that referenced
this pull request
Mar 5, 2021
…atsTests (#70006) (#70018) Since #69861 CFS files read from FrozenIndexInput create dedicated frozen shared cache files when they are sliced. This does not play well with some tests that use the randomReadAndSlice to read files: this method can create overlapping slice/clone reads operations which makes it difficult to assert anything about CFS files with partial cache. This commit prevent the tests to generate a .cfs file name when the partial cache is randomly picked up. As a follow up we should rework those test to make them more realistic with the new behavior. Closes #70000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #69861 CFS files read from
FrozenIndexInputcreate dedicated frozen shared cache files when they are sliced. This does not play well with some tests that use therandomReadAndSliceto read files: this method can create overlapping slice/clone reads operations which makes it difficult to assert anything about CFS files with partial cache.This commit prevent the tests to generate a .cfs file name when the partial cache is randomly picked up. As a follow up we should rework those test to make them more realistic with the new behavior.
Closes #70000