Simplify runtime fields factory function #71027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently use a TriFunction that takes the field name, the script params and the search lookup and returns a LeafFactory. Name and script params never change though and are available when the function is created, so the tri function can become a function search lookup -> leaf factory which is much easier to reason about.
javanna
added
:Search Foundations/Mapping
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
javanna
commented
Mar 30, 2021
| import org.elasticsearch.index.mapper.Mapper; | ||
| import org.elasticsearch.index.mapper.RuntimeField; | ||
| import org.elasticsearch.index.mapper.TextSearchInfo; | ||
| import org.elasticsearch.index.mapper.ValueFetcher; |
Member
Author
There was a problem hiding this comment.
this was a funny one, there were unused imports but checkstyle was not complaining? This comes from the recent package change I think.
Member
Author
|
run elasticsearch-ci/1 |
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Mar 31, 2021
We currently use a TriFunction that takes the field name, the script params and the search lookup and returns a LeafFactory. Name and script params never change though and are available when the function is created, so the tri function can become a function search lookup -> leaf factory which is much easier to reason about.
javanna
added a commit
that referenced
this pull request
Mar 31, 2021
We currently use a TriFunction that takes the field name, the script params and the search lookup and returns a LeafFactory. Name and script params never change though and are available when the function is created, so the tri function can become a function search lookup -> leaf factory which is much easier to reason about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use a TriFunction that takes the field name, the script params and the search lookup and returns a LeafFactory. Name and script params never change though and are available when the function is created, so the tri function can become a function search lookup -> leaf factory which is much easier to reason about.