Separe STATUS from RESULT in async search #72115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate metadata from the actual response in async search Getting the status of an async search could be costly if the response is already stored. In this case, we need to read the whole document's source, parse from the source async search response, and build from it a status response. This could take not trivial amount of time if the initial stored async search response is big. This PR: - separate STATUS into a separate stored binary field - make EXPIRATION_TIME also stored field (as we can update keep_alive without updating STATUS or RESULT), as we want status to reflect the most recent expiration time. - change retrieving status from GET request with _source to GET request with stored_fields=[STATUS, EXPIRATION_TIME] without _source. This allows faster retrieval of status. Relates to elastic#62947 Closes elastic#71223
mayya-sharipova
added
the
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
mayya-sharipova
added
>enhancement
v7.13.0
v8.0.0
and removed
Team:Search
|
main changes in AsyncTaskIndexService.java, all other changes is just corrections for these changes. |
|
We've discussed this again, and considering that Thus, closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate metadata from the actual response in async search
Getting the status of an async search could be costly if the response is
already stored. In this case, we need to read the whole document's source,
parse from the source async search response, and build from it a status
response. This could take not trivial amount of time if the initial
stored async search response is big.
This PR:
keep_alive without updating STATUS or RESULT), as we want
status to reflect the most recent expiration time.
GET request with stored_fields=[STATUS, EXPIRATION_TIME] without
_source. This allows faster retrieval of status.
Relates to #62947
Closes #71223