Synchronizes slowlog json keys with beats #74211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filebeat ships with dedicated fields for Elasticsearch slowlog This updates our ECS logger to report the slowlog keys under `elasticsearch.slowlog` https://github.com/elastic/beats/blob/23e4403ae093fcc8f7905345cad2c7ad256976d8/filebeat/module/elasticsearch/slowlog/test/slowlogs-json.log-expected.json This prevents clashes with ECS templates
pgomulka
reviewed
Jun 17, 2021
There was a problem hiding this comment.
let's fix the tests and it looks good!
This might need a follow up in filebeat test repository https://github.com/elastic/beats/tree/master/filebeat/module/elasticsearch/slowlog/test
| map.put("id", doc.id()); | ||
| map.put("elasticsearch.slowlog.message", index); | ||
| map.put("elasticsearch.slowlog.took", TimeValue.timeValueNanos(tookInNanos).toString()); | ||
| map.put("elasticsearch.slowlog.took_millis", ""+TimeUnit.NANOSECONDS.toMillis(tookInNanos)); |
There was a problem hiding this comment.
maybe we can use String.valueOf (I missed this bit when working on this last time..)
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
…elasticsearch into Mpdreamz-feature/ecs-slowlog-keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filebeat ships with dedicated fields for Elasticsearch slowlog
This updates our ECS logger to report the slowlog keys under
elasticsearch.slowloghttps://github.com/elastic/beats/blob/23e4403ae093fcc8f7905345cad2c7ad256976d8/filebeat/module/elasticsearch/slowlog/test/slowlogs-json.log-expected.json
This prevents clashes with ECS templates