Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rest Api Compatibility] Allow copy_settings flag for resize operations #75184

Merged
merged 3 commits into from
Jul 12, 2021
Merged

[Rest Api Compatibility] Allow copy_settings flag for resize operations #75184

merged 3 commits into from
Jul 12, 2021

Conversation

pgomulka
Copy link
Contributor

@pgomulka pgomulka commented Jul 9, 2021 •
edited
Loading

previously removed in #38514, deprecated in 7.x and defaulted to true.
With rest api compatibility and when value is true it is ignored and warning is emitted
when value is false, an exception is thrown

relates #51816

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@pgomulka
[Rest Api Compatibility] Allow copy_settings flag for resize operations
26d0a9c 
previously removed in elastic#38553, deprecated in 7.x and defaulted to true.
With rest api compatibility value is ignored and warning is emitted

relates elastic#51816
@pgomulka pgomulka added :Core/Infra/REST API REST infrastructure and utilities v8.0.0 labels Jul 9, 2021
@pgomulka pgomulka self-assigned this Jul 9, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jul 9, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@pgomulka pgomulka requested a review from jkakavas July 9, 2021 13:35
@pgomulka
Copy link
Contributor Author

@elasticmachine update branch

jkakavas
jkakavas approved these changes Jul 12, 2021
View reviewed changes
Copy link
Member

@jkakavas jkakavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pgomulka pgomulka merged commit 1855782 into elastic:master Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkakavas jkakavas jkakavas approved these changes

Assignees
No one assigned
Labels
:Core/Infra/REST API REST infrastructure and utilities >enhancement Team:Core/Infra Meta label for core/infra team v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgomulka @elasticmachine @jkakavas @jakelandis