Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Transform] Rename interim_results to align_checkpoints #76609

Merged
merged 3 commits into from
Aug 18, 2021
Merged

[Transform] Rename interim_results to align_checkpoints #76609

merged 3 commits into from
Aug 18, 2021

Conversation

przemekwitek
Copy link
Contributor

@przemekwitek przemekwitek commented Aug 17, 2021 •
edited
Loading

This PR:

  • renames transform setting interim_results to align_checkpoints
  • updates the logic of determining whether to align checkpoints
  • changes the default value (for interim_results it was false whereas for align_checkpoints it's true)
  • adds new unit tests / test assertions to make sure handling/updating the default is done correctly

Marked >non-issue as this PR only affects unreleased code introduced in #74004

Relates #62746

@przemekwitek przemekwitek force-pushed the transform_align_docs branch 3 times, most recently from 322175b to 106ba51 Compare August 18, 2021 07:34
@przemekwitek przemekwitek marked this pull request as ready for review August 18, 2021 08:27
@przemekwitek przemekwitek added the :ml/Transform Transform label Aug 18, 2021
@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Aug 18, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@przemekwitek przemekwitek merged commit ec07e42 into elastic:master Aug 18, 2021
@przemekwitek przemekwitek deleted the transform_align_docs branch August 18, 2021 11:58
@przemekwitek przemekwitek mentioned this pull request Aug 18, 2021
Merged
przemekwitek added a commit that referenced this pull request Aug 18, 2021
@przemekwitek
[Transform] Rename interim_results to align_checkpoints (#76609) (#76645
e8fc16e 
)
@lcawl lcawl mentioned this pull request Nov 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benwtrent benwtrent benwtrent approved these changes

Assignees
No one assigned
Labels
:ml/Transform Transform >non-issue Team:ML Meta label for the ML team v7.15.0 v8.0.0-alpha2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@przemekwitek @elasticmachine @benwtrent @jakelandis @elasticsearchmachine