Add trace.id to indexed deprecation logs #81524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elastic#75331 missed adding trace.id to indexed deprecation logs (they use ECSJsonLayout instead of ESJsonLayout).
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
@elasticmachine run elasticsearch-ci/packaging-tests-windows-sample |
grcevski
reviewed
Dec 8, 2021
| @@ -52,7 +52,7 @@ public static String getTraceId() { | |||
| public void format(LogEvent event, StringBuilder toAppendTo) { | |||
| String traceId = getTraceId(); | |||
| if (traceId != null) { | |||
| toAppendTo.append("\"trace.id\": \"" + traceId + "\""); | |||
| toAppendTo.append(traceId); | |||
There was a problem hiding this comment.
What's the reason for this change? Is it so that we can reuse the traceId formatter in EcsJsonLayout.java?
I wonder if this changes behaviour a bit, previously if traceId was null the format would not append anything, but now we might get "trace.id:null". Is that OK?
There was a problem hiding this comment.
Maybe notEmpty is smart enough ? :)
There was a problem hiding this comment.
yes, notEmpty will check if any of the variables in its "body" are evaluated .
There should be no field name if the value is null
and yes, the reason for this change was to reuse it in ECSJasonLayout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#75331 missed adding
trace.id to indexed deprecation logs (these use ECSJsonLayout instead of
ESJsonLayout).
gradle check?