[7.16] Script: Implicit context cache (#81552) #81560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script context cache is deprecated. In 7.16 the default value of `script.max_compilation_rate` was switched from `"use-context"`, to `"150/5m". That means uses would have to explicitly set "use-context" to use any of the context cache families of settings: `script.context.*.max_compilations_rate` `script.context.*.cache_max_size` `script.context.*.cache_expire` On upgrades to 7.16, if the customer was using the default and had set any of those settings without setting `script.max_compilation_rate: "use-context"`, the upgrade would be rejected. To avoid an unintentional breaking change, the script service will now **implicitly** use the script context cache if `script.max_compilation_rate` is **unset** and any of the context cache family of settings is set. The context cache will also be used if `script.max_compilation_rate: "use-context"`, as before. Fixes: elastic#81486 Backport: ba6c17d
|
part-2 failure was #81537 |
|
@elasticsearchmachine update branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.16: