In reverse nested aggregation, fix handling of the same child doc id being processed multiple times. #9345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Working through this and the one thing that looks like it would be beneficial for us and users, particularly given the complexity of these queries, is to have test examples that demonstrate a real use case rather than the very abstract foo/bar/baz examples. |
Contributor
|
Change to ReverseNestedAggregator looks good. |
Contributor
|
LGTM |
Member
Author
|
@markharwood I'll update the test to use a more realistic example. |
martijnvg
force-pushed
the
bugs/reverse_nested_agg/same_childDoc_bucketOrd_combination_occur_multiple_times
branch
2 times, most recently
from
13f7b0b to
22246ec
Compare
…times in the `reverse_nested` aggregation. Closes elastic#9263 Closes elastic#9345
martijnvg
force-pushed
the
bugs/reverse_nested_agg/same_childDoc_bucketOrd_combination_occur_multiple_times
branch
from
22246ec to
84d1f2e
Compare
clintongormley
changed the title
martijnvg
deleted the
bugs/reverse_nested_agg/same_childDoc_bucketOrd_combination_occur_multiple_times
branch
clintongormley
added
:Nested Docs
and removed
:Analytics/Aggregations
clintongormley
changed the title
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…times in the `reverse_nested` aggregation. Closes elastic#9263 Closes elastic#9345
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…times in the `reverse_nested` aggregation. Closes elastic#9263 Closes elastic#9345
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #9263
On the master, 1.x and 1.4 PR #9346 should be applied first.