Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiFilterGroup] Multi-select example not functional #4165

Closed
j-m opened this issue Oct 21, 2020 · 2 comments · Fixed by #5387
Closed

[EuiFilterGroup] Multi-select example not functional #4165

j-m opened this issue Oct 21, 2020 · 2 comments · Fixed by #5387
Labels
bug documentation Issues or PRs that only affect documentation - will not need changelog entries good first issue

Comments

@j-m
Copy link
Contributor

j-m commented Oct 21, 2020

... or at least as how I expected it to

Clicking on an EuiFilterSelectItem does not change it's checked state.

Issue #3735 makes it sounds like we are supposed to use EuiFilterGroup in conjunction with something else like EuiSelectable, but I can't find any examples of this. Have I missed something?

Also, this sentence is repeated

Add the prop withNext to remove the border between it and the next EuiFilterButton to visually group similar or opposite style filters.

@thompsongl
Copy link
Contributor

Hey @j-m, thanks for reporting this.
The component(s) do work, but the documentation "Multi-select" example appears to be incomplete. EuiFilterSelectItem requires an onClick handler to change its checked state and update the items list.

@thompsongl thompsongl added bug documentation Issues or PRs that only affect documentation - will not need changelog entries labels Oct 21, 2020
@thompsongl thompsongl changed the title [EuiFilterGroup] Does not work [EuiFilterGroup] Multi-select example not functional Oct 21, 2020
@thompsongl
Copy link
Contributor

thompsongl commented Oct 28, 2020

The onClick/checked state problems have been resolved, but there are some extra parts of functionality that could still be added to the example. See comments in #4178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug documentation Issues or PRs that only affect documentation - will not need changelog entries good first issue
Projects
None yet
2 participants