Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDatePicker] Docs/Types list unsupported react-datepicker props #5315

Closed
joeried opened this issue Oct 25, 2021 · 1 comment · Fixed by #5318
Closed

[EuiDatePicker] Docs/Types list unsupported react-datepicker props #5315

joeried opened this issue Oct 25, 2021 · 1 comment · Fixed by #5318
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries

Comments

@joeried
Copy link

joeried commented Oct 25, 2021

I'm not sure if I'm missing something, but it looks to me like both the types and docs for EuiDatePicker each list props from react-datepicker that are intentionally not supported by EuiDatePicker.

I noticed this with todayButton, but after a quick look at the code I believe monthsShown,showWeekNumbers,fixedHeight,dropdownMode,useShortMonthInDropdown,timeCaption,disabledKeyboardNavigation,isClearable,withPortal,showMonthYearDropdown are also affected.

@thompsongl
Copy link
Contributor

thompsongl commented Oct 25, 2021

Hey @joeried. Thanks for the exhaustive list!

You're correct that the lack of support is intentional, although I didn't know that so many documented props were unsupported.
We do not plan to add support for those unsupported props, and will in fact be removing react-datepicker in the near future.

We can, for now, at least remove the unsupported props from the table.

@thompsongl thompsongl added the documentation Issues or PRs that only affect documentation - will not need changelog entries label Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants