Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide some default design for expanding table rows #587

Closed
snide opened this issue Mar 28, 2018 · 8 comments
Closed

Provide some default design for expanding table rows #587

snide opened this issue Mar 28, 2018 · 8 comments

Comments

@snide
Copy link
Contributor

snide commented Mar 28, 2018

We should be able to clean up @cjcenizal's new expanding row tables with some nice defaults. Quick read is we should...

  • Use a caret system
  • Have a slight animation
  • Allow (optionally) for the entire row to be clickable.

We'll also need to factor this into @cchaos' responsive table work. Gut there is we just expose the values since we're now working in more vertical space.

image

@cchaos
Copy link
Contributor

cchaos commented Mar 28, 2018

I agree with all points except for the last. I do think we should continue the expansion concept into mobile. I can't imagine how much extra content could be spilt in that area and if we expose it all, it will become a HUGE table. I've seen it work well enough in mobile.

@snide
Copy link
Contributor Author

snide commented Mar 28, 2018

@cchaos sounds good to me.

@snide
Copy link
Contributor Author

snide commented Apr 16, 2018

@cchaos is working on this in #584

@cchaos cchaos mentioned this issue Apr 16, 2018
3 tasks
@snide snide mentioned this issue Apr 30, 2018
44 tasks
@cchaos cchaos removed their assignment May 29, 2018
@AdnanBoota
Copy link

Hi,

Is it possible to have the content inside the expandableRow horizontally? I have checked the documentation but didn't found anything about this?

Any idea, how to do it, please share!

image

@snide
Copy link
Contributor Author

snide commented Oct 20, 2019

@AdnanBoota It's using a simple EuiDescriptionList. You can find the props for this component on this page https://elastic.github.io/eui/#/display/description-list, but yes, it does allow for column based layouts using the type prop.

@AdnanBoota
Copy link

@snide Thanks a lot, it worked 👍

@cchaos
Copy link
Contributor

cchaos commented Mar 16, 2020

@snide Do you think this still needs to be addressed. Consumers can add any content they want in the expanded portion so I'm not entirely sure what we can do from the EUI side.

@snide
Copy link
Contributor Author

snide commented Mar 16, 2020

I think it's closable. Originally we wanted to have some pattern work here, but at this point we've seen these views used so differently it's best to keep them as a generic "throw stuff in here" option.

@snide snide closed this as completed Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants