From eb91aeb5342e45a019f4c625ac1f295bfe15daaa Mon Sep 17 00:00:00 2001 From: Stacey Gammon Date: Wed, 11 Jul 2018 15:51:52 -0400 Subject: [PATCH 1/2] whoops, made a bunch of properties required. --- CHANGELOG.md | 3 ++- src/components/flyout/index.d.ts | 8 ++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f8e67b12212..eb03a45efdb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,7 +1,8 @@ ## [`master`](https://github.com/elastic/eui/tree/master) -- Gave `EuiFlyout` close button a data-test-subj ([#1000](https://github.com/elastic/eui/pull/1000/files)) +- Make some proprties of `EuiFlyout` optional ([#1002](https://github.com/elastic/eui/pull/1002)) - Add typings for `EuiFlyout`, `EuiFlyoutBody`, `EuiFlyoutHeader`, and `EuiFlyoutFooter` ([#1001](https://github.com/elastic/eui/pull/1001)) +- Gave `EuiFlyout` close button a data-test-subj ([#1000](https://github.com/elastic/eui/pull/1000)) ## [`1.2.1`](https://github.com/elastic/eui/tree/v1.2.1) diff --git a/src/components/flyout/index.d.ts b/src/components/flyout/index.d.ts index 5cd7cc47cce..c6147d38240 100644 --- a/src/components/flyout/index.d.ts +++ b/src/components/flyout/index.d.ts @@ -1,15 +1,15 @@ declare module '@elastic/eui' { export interface EuiFlyoutProps { onClose: () => void; - size: 's' | 'm' | 'l'; + size?: 's' | 'm' | 'l'; /** * Hides the default close button. You must provide another close button somewhere within the flyout. */ - hideCloseButton: boolean; + hideCloseButton?: boolean; /** * Locks the mouse / keyboard focus to within the flyout */ - ownFocus: boolean; + ownFocus?: boolean; } export const EuiFlyout: React.SFC< @@ -20,7 +20,7 @@ declare module '@elastic/eui' { export const EuiFlyoutBody: React.SFC; export interface EuiFlyoutHeaderProps { - hasBorder: boolean; + hasBorder?: boolean; } export const EuiFlyoutHeader: React.SFC; From d04eb8772bc07b80be4fcdfb442d317ea69e3cf9 Mon Sep 17 00:00:00 2001 From: Stacey Gammon Date: Wed, 11 Jul 2018 15:53:55 -0400 Subject: [PATCH 2/2] use the right pr # --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index eb03a45efdb..9c4d53a10ad 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,6 @@ ## [`master`](https://github.com/elastic/eui/tree/master) -- Make some proprties of `EuiFlyout` optional ([#1002](https://github.com/elastic/eui/pull/1002)) +- Make some proprties of `EuiFlyout` optional ([#1003](https://github.com/elastic/eui/pull/1003)) - Add typings for `EuiFlyout`, `EuiFlyoutBody`, `EuiFlyoutHeader`, and `EuiFlyoutFooter` ([#1001](https://github.com/elastic/eui/pull/1001)) - Gave `EuiFlyout` close button a data-test-subj ([#1000](https://github.com/elastic/eui/pull/1000))