From c7ce81ded13d7bc74ebc1e8e8ed9aecc2f6749e1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicol=C3=A1s=20Bevacqua?= Date: Fri, 10 Aug 2018 17:19:11 -0300 Subject: [PATCH 1/2] Fix bug in checkbox --- src/components/form/checkbox/checkbox.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/components/form/checkbox/checkbox.js b/src/components/form/checkbox/checkbox.js index 0f905f31399..2371a201261 100644 --- a/src/components/form/checkbox/checkbox.js +++ b/src/components/form/checkbox/checkbox.js @@ -85,13 +85,13 @@ export class EuiCheckbox extends Component { this.props.inputRef(input); } - if (input) { - this.invalidateIndeterminate(); - } + this.invalidateIndeterminate(); } invalidateIndeterminate() { - this.inputRef.indeterminate = this.props.indeterminate; + if (this.inputRef) { + this.inputRef.indeterminate = this.props.indeterminate; + } } } From d66b56c949c0c11a9ccacf7de787df2b5d04e097 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicol=C3=A1s=20Bevacqua?= Date: Fri, 10 Aug 2018 17:22:18 -0300 Subject: [PATCH 2/2] Update changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d63d983bc46..cd36b2d6b85 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,6 @@ ## [`master`](https://github.com/elastic/eui/tree/master) -No public interface changes since `3.5.0`. +- Fixed a bug around `indeterminate` checkboxes ([#1110](https://github.com/elastic/eui/pull/1110)) ## [`3.5.0`](https://github.com/elastic/eui/tree/v3.5.0)