Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable radio group option #1111

Merged
merged 3 commits into from
Aug 13, 2018
Merged

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Aug 10, 2018

I need a way to disable radio group options individually.

screen shot 2018-08-10 at 3 06 58 pm

@nreese nreese requested a review from cjcenizal August 10, 2018 21:14
@cjcenizal cjcenizal requested review from chandlerprall and removed request for cjcenizal August 10, 2018 21:21
@cjcenizal
Copy link
Contributor

I'm going to defer review to @chandlerprall since I'm pretty swamped today.

@@ -24,7 +24,7 @@ export const EuiRadioGroup = ({
checked={option.id === idSelected}
label={option.label}
value={option.value}
disabled={disabled}
disabled={disabled || option.disabled}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The options propType needs the disabled boolean property to be added.

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes LGTM

@nreese nreese merged commit a13628a into elastic:master Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants