Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds AWS and GCP logos #1135

Merged
merged 4 commits into from
Aug 23, 2018
Merged

Adds AWS and GCP logos #1135

merged 4 commits into from
Aug 23, 2018

Conversation

gjones
Copy link
Contributor

@gjones gjones commented Aug 22, 2018

Closes: #1133

Notes

We need platform logos in Cloud that will work with dark mode. I'm adding mono versions for this use and also colour versions in case other people have a need for these icons.

Screenshots

screen shot 2018-08-22 at 13 07 35
screen shot 2018-08-22 at 13 07 40
screen shot 2018-08-22 at 13 25 56
screen shot 2018-08-22 at 13 26 09

@gjones gjones requested review from snide and cchaos August 22, 2018 17:43
@gjones gjones changed the title 1133 aws gcp logos Adds AWS and GCP logos Aug 22, 2018
@gjones
Copy link
Contributor Author

gjones commented Aug 22, 2018

Just a note on this, regarding the Amazon colour version, it doesn't work well on dark mode. The reason why I haven't removed the fill is that the text is actually a very dark blue. Amazon's guidelines are fine with using monotone versions of their logos, but if you want to use colour it should be their brand ones. That's why I left the blue in.

I'm happy to remove the fill from the characters if someone has a strong opinion on it, as I say, I probably wont be using the colour versions in cloud so it doesn't matter to me.

@snide
Copy link
Contributor

snide commented Aug 22, 2018

@cchaos I asked @gjones to start providing mono icons (right now as a suffix) if they're using them. I think eventually we're going to be a place where we're going to want a full set of mono icons (removed of fill) as its the only good way to get our of our theming woes with logos.

For the color ones im pretty wary of changing colors of big brands just so they work against dark theming. I know we have discussions around this a bunch, but this at least seems non-destruction and something we can expand on eventually.

Do you have any strong opinions before we merge this stuff down?

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope ;) LGTM

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we're getting by on a wink here!

@snide
Copy link
Contributor

snide commented Aug 23, 2018

@gjones Don't forget the changelog before you merge.

@gjones gjones merged commit ba92649 into elastic:master Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants