Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlexGrid now accepts columns={1} #1210

Merged
merged 3 commits into from
Sep 24, 2018
Merged

FlexGrid now accepts columns={1} #1210

merged 3 commits into from
Sep 24, 2018

Conversation

snide
Copy link
Contributor

@snide snide commented Sep 24, 2018

Summary

EuiFlexGrid now accepts columns={1}. This was at the request of @walterra.

Screen just shows that it's working, I didn't add this example to the docs.

image

Checklist

  • This was checked in mobile
    - [ ] This was checked in IE11
    - [ ] This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
    - [ ] This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
    - [ ] This was checked against keyboard-only and screenreader scenarios

@snide snide requested a review from cchaos September 24, 2018 21:03
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM

@snide snide merged commit cff4915 into elastic:master Sep 24, 2018
@snide snide deleted the flex/grid_1 branch September 24, 2018 21:53
@snide snide mentioned this pull request Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants