Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some EuiSuperSelect fixes #1295

Merged
merged 2 commits into from
Nov 7, 2018
Merged

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Nov 7, 2018

  • Fixed size of context menu when there’s no initial selection
  • Don’t use underlines for focus states, but background colors instead - It's possible to have blocks of text as options which looks odd to underline a whole paragraph


To test:

Change this state to null:

value: this.options[1].value,


Checklist

- [ ] This was checked in mobile

  • This was checked in IE11
  • This was checked in dark mode
    - [ ] Any props added have proper autodocs
    - [ ] Documentation examples were added
  • A changelog entry exists and is marked appropriately
    - [ ] This was checked for breaking changes and labeled appropriately
    - [ ] Jest tests were updated or added to match the most common scenarios
    - [ ] This was checked against keyboard-only and screenreader scenarios
    - [ ] This required updates to Framer X components

- Fixes size of context menu when there’s no initial selection
- Don’t use underlines for focus states, but background colors instead
@cchaos cchaos requested review from chandlerprall and snide November 7, 2018 18:16
@chandlerprall
Copy link
Contributor

jenkins test this

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes LGTM

@cchaos cchaos merged commit 99464ed into elastic:master Nov 7, 2018
@cchaos cchaos deleted the fix-super-select-size branch November 7, 2018 21:49
@snide snide mentioned this pull request Nov 30, 2018
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants