Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set milliseconds to zero when handling time change in react-datepicker #1361

Merged
merged 2 commits into from
Dec 10, 2018
Merged

set milliseconds to zero when handling time change in react-datepicker #1361

merged 2 commits into from
Dec 10, 2018

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Dec 9, 2018

Summary

react-datepicker Time onChange callback does not zero out milliseconds when setting the time. This PR fixes that problem so when times are selected, milliseconds are set to zero.

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@nreese nreese mentioned this pull request Dec 9, 2018
Merged
10 tasks
@nreese nreese requested a review from chandlerprall December 10, 2018 14:44
chandlerprall
chandlerprall approved these changes Dec 10, 2018
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chandlerprall
Copy link
Contributor

jenkins test this

1 similar comment
@nreese
Copy link
Contributor Author

nreese commented Dec 10, 2018

jenkins test this

@nreese nreese merged commit 77615ac into elastic:master Dec 10, 2018
@snide snide mentioned this pull request Dec 11, 2018
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nreese @chandlerprall