Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new bell icon #1447

Merged
merged 8 commits into from
Jan 23, 2019
Merged

Add new bell icon #1447

merged 8 commits into from
Jan 23, 2019

Conversation

formgeist
Copy link
Contributor

Summary

Adding a new bell icon. We might use this for new alerting/notification features in APM.

screenshot 2019-01-17 at 10 04 10

screenshot 2019-01-17 at 14 55 49

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • [ ]~~ This was checked for breaking changes and labeled appropriately~~
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@formgeist formgeist requested a review from a team January 17, 2019 13:56
@cchaos
Copy link
Contributor

cchaos commented Jan 17, 2019

When exporting icons from sketch, you'll want to be sure to use SVGO and change the path layer to not be a mask (that will get rid of the extra defs layer and will just be the plain path). They also need to keep the viewbox (this keeps it in proportion when scaling).

I did a quick export for you. EUI 2.0 actually makes this a lot easier for you because it doesn't rely on masks.

Here's the svg code

<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" viewBox="0 0 16 16">
  <path fill-rule="evenodd" d="M2.31646443,12 L12.6836362,12 C12.4964159,11.2964546 12.4037706,10.3089281 12.336033,8.9634913 C12.2664257,7.58091744 12.232924,7.07529429 12.1458783,6.35085462 C12.117581,6.11534983 12.085766,5.88907001 12.0498803,5.67021349 C11.7398351,3.77933885 10.5442929,2.74814708 8.34205264,2.53962274 C8.44202035,2.38395134 8.49999995,2.1987466 8.49999995,2 C8.49999995,1.44771525 8.0522847,1 7.49999996,1 C6.94771521,1 6.49999996,1.44771525 6.49999996,2 C6.49999996,2.19875514 6.55798454,2.38396726 6.65796017,2.53964282 C4.45594546,2.74825739 3.26051448,3.77943998 2.95048592,5.67021349 C2.91460001,5.88907116 2.88278327,6.11535275 2.85448266,6.35086072 C2.76743966,7.07520286 2.73393177,7.58064011 2.66426105,8.96319272 C2.59645331,10.3087762 2.50374824,11.296399 2.31646443,12 Z M13.158645,13 L1.84138084,13 C1.53255249,13.3532355 1.10418166,13.5 0.499999997,13.5 C0.223857624,13.5 7.91033905e-14,13.2761424 8.2600593e-14,13 C8.61533067e-14,12.7238576 0.223857624,12.5 0.499999997,12.5 C1.28610027,12.5 1.52422506,11.7169006 1.66552836,8.91286377 C1.73641878,7.50610729 1.77081866,6.98721524 1.86162562,6.23155072 C1.89158283,5.98225704 1.92538416,5.74186107 1.96366374,5.50840508 C2.29841112,3.46687871 3.51012637,2.19469978 5.52001924,1.71593129 C5.65794768,0.745902262 6.49186641,-3.28626015e-14 7.49999996,-3.28626015e-14 C8.50810221,-3.28626015e-14 9.34200048,0.745855971 9.47996782,1.71584099 C11.4900875,2.19453979 12.701934,3.46675034 13.0367025,5.50840508 C13.0749825,5.74186401 13.1087826,5.98226229 13.1387368,6.23155682 C13.2295478,6.98733325 13.2639417,7.50642113 13.334768,8.91320883 C13.4759302,11.7170414 13.7139774,12.5 14.5,12.5 C14.7761424,12.5 15,12.7238576 15,13 C15,13.2761424 14.7761424,13.5 14.5,13.5 C13.8958084,13.5 13.4674478,13.3532386 13.158645,13 Z M5.49999997,14 L9.49999994,14 C9.49999994,15.1045695 8.60456945,16 7.49999996,16 C6.39543046,16 5.49999997,15.1045695 5.49999997,14 Z"/>
</svg>

@formgeist
Copy link
Contributor Author

@cchaos Thanks! I was battling with the SVG export all morning and exporting it with SVGO enabled (Sketch plugin), but also using https://jakearchibald.github.io/svgomg/ to clean it even further. I finally managed to export one that would not have a fill, but I seem to have forgotten about the rest.

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, LGTM

@formgeist formgeist merged commit 45d59e7 into elastic:master Jan 23, 2019
@formgeist formgeist deleted the add-bell-icon branch January 23, 2019 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants