Fix EuiFilterGroupButton bolding with notification and... #1455
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things ended up getting fixed with this one
1. I realized that when sending
textProps
andcontentProps
to EuiButton and EuiButtonEmpty, I wasn't accounting for the fact that it would replaceclassName
is passed down.So these components now append the button classNames to any classNames passed in those objects before applying those props objects to the element.
2. The bolding trick now works on EuiFilterGroupButtons that have the numFilters notification
Before
After
Checklist
[ ] This was checked in mobile[ ] Any props added have proper autodocs[ ] Documentation examples were added[ ] This was checked for breaking changes and labeled appropriately[ ] Jest tests were updated or added to match the most common scenarios[ ] This was checked against keyboard-only and screenreader scenarios[ ] This required updates to Framer X components