Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EuiFilterGroupButton bolding with notification and... #1455

Merged
merged 4 commits into from
Jan 18, 2019

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Jan 17, 2019

Two things ended up getting fixed with this one

1. I realized that when sending textProps and contentProps to EuiButton and EuiButtonEmpty, I wasn't accounting for the fact that it would replace className is passed down.

So these components now append the button classNames to any classNames passed in those objects before applying those props objects to the element.

2. The bolding trick now works on EuiFilterGroupButtons that have the numFilters notification

Before

After

Checklist

  • [ ] This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • [ ] Any props added have proper autodocs
  • [ ] Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • [ ] This was checked for breaking changes and labeled appropriately
  • [ ] Jest tests were updated or added to match the most common scenarios
  • [ ] This was checked against keyboard-only and screenreader scenarios
  • [ ] This required updates to Framer X components

cchaos added 2 commits January 17, 2019 18:02
… so they don’t override classes
So that the bold weight shift works properly
@cchaos cchaos added the bug label Jan 17, 2019
@cchaos cchaos requested review from chandlerprall and snide January 17, 2019 23:08
@cchaos
Copy link
Contributor Author

cchaos commented Jan 17, 2019

Found the same issue on EuiBadge and fixed that as well.

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM

@cchaos cchaos merged commit e075939 into elastic:master Jan 18, 2019
@cchaos cchaos deleted the filter-group-bold-fix branch January 18, 2019 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants