-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow EuiListGroupItem link text to wrap #1459
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, rest looks good.
c1d2d4f
to
ff5af1d
Compare
ff5af1d
to
c04cc9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized that it might be really cumbersome to have to apply this to each individual item. Can you also allow it to be passed via the full EuiListGroup
?
@cchaos Going a step further, perhaps it should only be a prop on the |
Well a consumer may not always be passing in items via the |
I think even in that case you'd still have an |
But then you'd have to do something like
to
? Though, I think just allowing it be provided to both is the most flexible. |
0d148fa
to
658e75c
Compare
@snide The DISPLAY_TYPES are now being exported and used in the PropTypes. @cchaos This latest commit moves the prop to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure that's fine. I had a couple nit-picky things but I'll defer to your judgement. LG!
5c0e385
to
18ae98d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be working well. It's kind of odd to see the scrollbars and extra actions disappear before the sidebar starts animating closed, but those are things we can tinker with later.
Just a comment about min-width
below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JS changes LGTM
6f3740d
to
2b23df3
Compare
Summary
In testing the new side nav in Kibana, it is preferred that long link text in the flyout be allowed to wrap. The flyout has more vertical space than the main menu and it is common for saved objects to have lengthy titles.
This PR adds an
isWrappable
prop toEuiListGroupItem
that provide the ability to make the text wrap as desired. The docs examples for the Nav Drawer shows the result. pictured below.Checklist
Jest tests were updated or added to match the most common scenariosThis required updates to Framer X components