Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix font stack for monospace font #1465

Merged
merged 2 commits into from
Jan 23, 2019
Merged

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Jan 23, 2019

@weltenwort Caught a bug during the assets build process that spit out the monospace font as:

"euiCodeFontFamily": "Roboto Mono Consolas Menlo 'courier', 'new' monospace",

This just removes new and fixes spacing issues to it now spits out as:

"euiCodeFontFamily": "'Roboto Mono', 'Consolas', 'Menlo', 'Courier', monospace",

Checklist

  • [ ] This was checked in mobile
  • [ ] This was checked in IE11
  • [ ] This was checked in dark mode
  • [ ] Any props added have proper autodocs
  • [ ] Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • [ ] This was checked for breaking changes and labeled appropriately
  • [ ] Jest tests were updated or added to match the most common scenarios
  • [ ] This was checked against keyboard-only and screenreader scenarios
  • [ ] This required updates to Framer X components

@cchaos cchaos added the bug label Jan 23, 2019
@cchaos cchaos requested review from chandlerprall and snide January 23, 2019 16:59
@cchaos cchaos merged commit d9ab789 into elastic:master Jan 23, 2019
@cchaos cchaos deleted the fix-monospace branch January 23, 2019 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants