From 288b1863a729fc532783f4ca9a152af755205eac Mon Sep 17 00:00:00 2001 From: cchaos Date: Fri, 12 Jul 2019 16:35:29 -0400 Subject: [PATCH 1/3] Centered the square of the popout icon in the artboard --- src/components/icon/__snapshots__/icon.test.tsx.snap | 3 ++- src/components/icon/assets/popout.js | 5 ++++- src/components/icon/assets/popout.svg | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/components/icon/__snapshots__/icon.test.tsx.snap b/src/components/icon/__snapshots__/icon.test.tsx.snap index 9dd9c382226..5fc7695e3e4 100644 --- a/src/components/icon/__snapshots__/icon.test.tsx.snap +++ b/src/components/icon/__snapshots__/icon.test.tsx.snap @@ -5476,7 +5476,8 @@ exports[`EuiIcon props type popout is rendered 1`] = ` xmlns="http://www.w3.org/2000/svg" > `; diff --git a/src/components/icon/assets/popout.js b/src/components/icon/assets/popout.js index 05650c56aa8..b194e08d133 100644 --- a/src/components/icon/assets/popout.js +++ b/src/components/icon/assets/popout.js @@ -7,7 +7,10 @@ const EuiIconPopout = props => ( viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg" {...props}> - + ); diff --git a/src/components/icon/assets/popout.svg b/src/components/icon/assets/popout.svg index 6d425445bdf..b9a5f0a8e02 100644 --- a/src/components/icon/assets/popout.svg +++ b/src/components/icon/assets/popout.svg @@ -1,3 +1,3 @@ - + From d3446ad1fd3d3b132454a6add33219f27ecaea27 Mon Sep 17 00:00:00 2001 From: cchaos Date: Fri, 12 Jul 2019 16:44:36 -0400 Subject: [PATCH 2/3] cl --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c21327a270a..e2a847c779d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,6 @@ ## [`master`](https://github.com/elastic/eui/tree/master) -No public interface changes since `12.3.1`. +- Centered the square of the `popout` glyph in the artboard ([#2120](https://github.com/elastic/eui/pull/2120)) ## [`12.3.1`](https://github.com/elastic/eui/tree/v12.3.1) From 4c94afc83c1bea36847f28ff1aa808cbb4afa484 Mon Sep 17 00:00:00 2001 From: cchaos Date: Mon, 15 Jul 2019 09:40:00 -0400 Subject: [PATCH 3/3] Remove fill-mode --- src/components/icon/__snapshots__/icon.test.tsx.snap | 1 - src/components/icon/assets/popout.js | 5 +---- src/components/icon/assets/popout.svg | 2 +- 3 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/components/icon/__snapshots__/icon.test.tsx.snap b/src/components/icon/__snapshots__/icon.test.tsx.snap index 5fc7695e3e4..8d55de80bb4 100644 --- a/src/components/icon/__snapshots__/icon.test.tsx.snap +++ b/src/components/icon/__snapshots__/icon.test.tsx.snap @@ -5477,7 +5477,6 @@ exports[`EuiIcon props type popout is rendered 1`] = ` > `; diff --git a/src/components/icon/assets/popout.js b/src/components/icon/assets/popout.js index b194e08d133..ada795313f0 100644 --- a/src/components/icon/assets/popout.js +++ b/src/components/icon/assets/popout.js @@ -7,10 +7,7 @@ const EuiIconPopout = props => ( viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg" {...props}> - + ); diff --git a/src/components/icon/assets/popout.svg b/src/components/icon/assets/popout.svg index b9a5f0a8e02..9b0270504f6 100644 --- a/src/components/icon/assets/popout.svg +++ b/src/components/icon/assets/popout.svg @@ -1,3 +1,3 @@ - +