Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper classname for flexGroup alignItems prop #257

Merged
merged 3 commits into from
Jan 3, 2018

Conversation

snide
Copy link
Contributor

@snide snide commented Jan 3, 2018

The class being used in the component was not the one being used in the sass. This uses the proper one used in the sass. Since the css is not effected, this is a non-breaking change.

@snide snide added the bug label Jan 3, 2018
@snide snide requested a review from nreese January 3, 2018 17:29
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, don't forget to update the change log

CHANGELOG.md Outdated
@@ -2,7 +2,8 @@

**Bug fixes**

- Clicking the downArrow icon in `EuiSelect` now triggers selection. [(#237)[https://github.com/elastic/eui/pull/255]]
- Proper classname for flexGroup alignItems prop. [(#256)[https://github.com/elastic/eui/pull/256]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you used the wrong PR number. This PR is 257

@snide snide merged commit e869da8 into elastic:master Jan 3, 2018
@snide snide deleted the bug/flex_align branch January 3, 2018 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants