Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiColorPicker] Add optional color value input #3336

Merged
merged 14 commits into from
Apr 21, 2020
Merged

[EuiColorPicker] Add optional color value input #3336

merged 14 commits into from
Apr 21, 2020

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Apr 16, 2020 •
edited by cchaos
Loading

Summary

Closes #3055 by adding an optional prop to display a color value input inside the popover panel.
A nice benefit is that the new prop and rendered output can be used by EuiColorStops, which simplifies those internals quite a bit.

imageimage

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@thompsongl thompsongl requested a review from cchaos April 16, 2020 17:26
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3336/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3336/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3336/

@thompsongl thompsongl requested a review from cchaos April 20, 2020 15:14
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3336/

@thompsongl @cchaos
Update src-docs/src/views/color_picker/color_picker_example.js
2f41b8a 
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3336/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3336/

@thompsongl thompsongl requested a review from cchaos April 21, 2020 17:19
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3336/

@cchaos
Copy link
Contributor

cchaos commented Apr 21, 2020

Sorry two more quick things.

  1. Can we align the spacing between the top and bottom inputs. Make the top space size="s".

Screen Shot 2020-04-21 at 14 09 59 PM

  1. Is it possible to remove the trash icon from the readOnly state? It's just adds visual noise.

Screen Shot 2020-04-21 at 14 08 26 PM

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3336/

cchaos
cchaos approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Sweet thanks!

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3336/

@thompsongl
Copy link
Contributor Author

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3336/

@thompsongl thompsongl merged commit 409edb9 into elastic:master Apr 21, 2020
@thompsongl thompsongl mentioned this pull request May 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EuiColorPicker option for inline color input
3 participants
@thompsongl @kibanamachine @cchaos