From 438bafb7e4c5ad400fd3e034de72df9aa1efab35 Mon Sep 17 00:00:00 2001 From: Akash Gupta Date: Wed, 10 Feb 2021 08:37:45 +0530 Subject: [PATCH 1/2] Fixed onClose invoking with unexpected parameter --- src/components/flyout/flyout.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/components/flyout/flyout.tsx b/src/components/flyout/flyout.tsx index af48f2a10e6..0e942953483 100644 --- a/src/components/flyout/flyout.tsx +++ b/src/components/flyout/flyout.tsx @@ -134,7 +134,9 @@ export const EuiFlyout: FunctionComponent = ({ iconType="cross" color="text" aria-label={closeButtonAriaLabel || closeAriaLabel} - onClick={onClose} + onClick={() => { + onClose(); + }} data-test-subj="euiFlyoutCloseButton" /> )} From 9870a15ea4f828d2d90f2c07c88c0f9f8f68ccb2 Mon Sep 17 00:00:00 2001 From: Akash Gupta Date: Wed, 10 Feb 2021 08:40:53 +0530 Subject: [PATCH 2/2] cl --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index c59462f7794..e0a7bd31f35 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ **Bug fixes** +- Fixed `onClose` invoking with unexpected parameter in `EuiFlyout` ([#4505](https://github.com/elastic/eui/pull/4505)) - Fixed invalid color entry passed to `EuiBadge` color prop ([#4481](https://github.com/elastic/eui/pull/4481)) - Fixed `EuiCodeBlock` focus-state if content overflows ([#4463]https://github.com/elastic/eui/pull/4463)