Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiFlyout] - Fixed onClose invoked with unexpected parameter #4505

Merged
merged 2 commits into from
Feb 10, 2021
Merged

[EuiFlyout] - Fixed onClose invoked with unexpected parameter #4505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
438bafb
Fixed onClose invoking with unexpected parameter
akashgp09 Feb 10, 2021
9870a15
cl
akashgp09 Feb 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

**Bug fixes**

- Fixed `onClose` invoking with unexpected parameter in `EuiFlyout` ([#4505](https://github.com/elastic/eui/pull/4505))
- Fixed invalid color entry passed to `EuiBadge` color prop ([#4481](https://github.com/elastic/eui/pull/4481))
- Fixed `EuiCodeBlock` focus-state if content overflows ([#4463]https://github.com/elastic/eui/pull/4463)

Expand Down
4 changes: 3 additions & 1 deletion src/components/flyout/flyout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,9 @@ export const EuiFlyout: FunctionComponent<EuiFlyoutProps> = ({
iconType="cross"
color="text"
aria-label={closeButtonAriaLabel || closeAriaLabel}
onClick={onClose}
onClick={() => {
onClose();
}}
data-test-subj="euiFlyoutCloseButton"
/>
)}
Expand Down