EuiSearchBox - pass rest to EuiFieldSearch #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisronline
suggested changes
Mar 15, 2018
| @@ -31,6 +31,16 @@ export class EuiSearchBox extends Component { | |||
| } | |||
|
|
|||
| render() { | |||
| const { | |||
| placeholder, | |||
There was a problem hiding this comment.
We should probably just use these variables down below since we're defining them (so placeholder={placeholder} instead of placeholder={this.props.placeholder}
There was a problem hiding this comment.
good catch. I replaced all uses of this.props.x with the local variables
cjcenizal
approved these changes
Mar 15, 2018
CHANGELOG.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| # [`master`](https://github.com/elastic/eui/tree/master) | |||
|
|
|||
| No public interface changes since `0.0.27`. | |||
| - `EuiSearchBox` pass rest to `EuiFieldSearch` ([#514](https://github.com/elastic/eui/pull/514)) | |||
There was a problem hiding this comment.
Can we make this more specific?
`EuiSearchBox` now passes unused props through to `EuiFieldSearch`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow consumers of
EuiInMemoryTablea way to pass attributes toEuiFieldSearchused inEuiSearchBox