EuiComboBox: Add buttons for clearing and opening/closing the combo box #698
Conversation
|
go ahead. Thanks |
|
Quick question, are we sure we should be flipping the caret? I'm just thinking in terms of consistency with our other dropdowns like context menus and filters:
|
|
@cchaos I'd keep it pointed down. |
|
Should I make that change, or is Design putting something together? |
|
@nreese I'll pull something together |
|
@nreese I created a PR against your fork |
|
@cchaos Thanks for the changes. |
|
@snide Any ideas why CI is failing? All tests run locally |
|
jenkins test this |
|
Looks like this is happening in a couple PRs due to a docker issue. I'm off tomorrow, but you or @chandlerprall might want to ping the infra channel and @Crazybus (who set some of this up) for assistance. Likely someone there can help you. If this is blocking you, as long as the tests are passing locally feel free to merge, but usually that team is really quick, so I'm betting they can help out. |
|
jenkins test this |
|
jenkins test this |
|
@nreese Tests pass on this. Just needs a changelog update, then I think you're good to go. |
…rlying componenets change
* Added `onClear` prop to `EuiFormControlLayout` This will allow these extras to properly position according to what is visible and allow for other inputs to utilize it as well. * Adding `isClearable` back in * Adding onClose/onOpen back in and allowing a `onIconClick` prop on the EuiFormControlLayout that will then wrap the icon in a button.
fixes #681