Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiFlyout] Resolve disparity between push flyouts and overlay flyouts #7065

Merged
merged 9 commits into from
Aug 11, 2023
Merged

[EuiFlyout] Resolve disparity between push flyouts and overlay flyouts #7065

merged 9 commits into from
Aug 11, 2023

Commits on Aug 10, 2023

  1. [misc cleanup] move props that don't need to be after ...rest to be… 

    …fore rest

- these props are already extracted out and don't exist in `...rest`, so there's nothing to override
    @cee-chen
    cee-chen committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    1653966 View commit details
    Browse the repository at this point in the history

  2. Remove dialog role + tabIndex from push flyouts 

    Push flyouts are already not receiving screen reader specific text, and in the case of the new beta collapsible nav, the push flyout truly isn't a dialog
    @cee-chen
    cee-chen committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    bf1e24d View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary data-autofocus prop from push flyouts 

    - only used if the focus trap is enabled, and it's not, so we should just lose it
    @cee-chen
    cee-chen committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    d84f0c6 View commit details
    Browse the repository at this point in the history

  4. [misc enhancement] Allow consumers to pass custom aria-describedby … 

    …IDs to flyouts
    @cee-chen
    cee-chen committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    0d7df8a View commit details
    Browse the repository at this point in the history

  5. [EuiCollapsibleNavBeta] Add an aria-label for overlay mode only

    @cee-chen
    cee-chen committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    39b5bf3 View commit details
    Browse the repository at this point in the history

  6. [Docs] Add warning about push flyout accessibility 

    + misc fragment cleanup
    @cee-chen
    cee-chen committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    7a6a831 View commit details
    Browse the repository at this point in the history

  7. changelog

    @cee-chen
    cee-chen committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    6b30b77 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. [PR feedback] copy 

    Co-authored-by: Trevor Pierce <1Copenut@users.noreply.github.com>
    @cee-chen @1Copenut
    cee-chen and 1Copenut authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    3b1292d View commit details
    Browse the repository at this point in the history

  2. [PR feedback] Site menu aria-label

    @cee-chen
    cee-chen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    c9e6634 View commit details
    Browse the repository at this point in the history