Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiFlyoutResizable] Fix onResize not appearing in props table #7750

Merged
merged 2 commits into from
May 14, 2024

Conversation

cee-chen
Copy link
Member

@cee-chen cee-chen commented May 13, 2024

Summary

@PhilippeOberti super helpfully pointed out that the onResize prop added in #7464 doesn't actually show up in the props table 🤦

QA

General checklist

  • Docs site QA
    • Props have proper autodocs (using @default if default values are missing) and playground toggles

- it must be inheriting from HTML attributes somewhere?? so we need to omit it
- move resizable specific props above generic flyout props in table also
@cee-chen cee-chen added documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog labels May 13, 2024
@cee-chen cee-chen marked this pull request as ready for review May 13, 2024 20:23
@cee-chen cee-chen requested a review from a team as a code owner May 13, 2024 20:23
Copy link
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🐈‍⬛ LGTM!

@cee-chen
Copy link
Member Author

Not sure what's up with the hanging GH jobs, going to admin merge

@cee-chen
Copy link
Member Author

Oh wait lol it won't let me. Githuuuuub!!

@cee-chen cee-chen enabled auto-merge (squash) May 14, 2024 15:39
@kibanamachine
Copy link

Preview staging links for this PR:

@cee-chen cee-chen merged commit dd0ad53 into elastic:main May 14, 2024
5 checks passed
@cee-chen cee-chen deleted the flyout-resizable-props-table branch May 14, 2024 16:26
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants