Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Update beats import to v7.17.18 (#3391)" #3441

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Revert "Update beats import to v7.17.18 (#3391)" #3441

merged 3 commits into from
Apr 9, 2024

Conversation

juliaElastic
Copy link
Contributor

This reverts commit b4de6f5.

Closes #3435

What is the problem this PR solves?

// Please do not just reference an issue. Explain WHAT the problem this PR solves here.

How does this PR solve the problem?

// Explain HOW you solved the problem in your code. It is possible that during PR reviews this changes and then this section should be updated.

How to test this PR locally

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Related issues

@juliaElastic juliaElastic marked this pull request as ready for review April 8, 2024 15:06
@juliaElastic juliaElastic requested review from a team as code owners April 8, 2024 15:06
cmacknz
cmacknz previously approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@cmacknz cmacknz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding control plane approval.

jsoriano
jsoriano previously approved these changes Apr 8, 2024
View reviewed changes
@michel-laterman michel-laterman dismissed stale reviews from jsoriano and cmacknz via f1febbf April 8, 2024 17:16
michel-laterman
michel-laterman reviewed Apr 8, 2024
View reviewed changes
Dockerfile.build
@@ -1,5 +1,5 @@
ARG GO_VERSION
FROM golang:${GO_VERSION}-buster
FROM golang:${GO_VERSION}-bullseye
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to update as 1.21.9-buster does not exist

@jlind23 jlind23 merged commit b9e2434 into elastic:7.17 Apr 9, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michel-laterman michel-laterman michel-laterman left review comments

@jlind23 jlind23 jlind23 approved these changes

@cmacknz cmacknz cmacknz left review comments

@jsoriano jsoriano jsoriano left review comments

@AndersonQ AndersonQ Awaiting requested review from AndersonQ AndersonQ is a code owner automatically assigned from elastic/elastic-agent-control-plane

@michalpristas michalpristas Awaiting requested review from michalpristas michalpristas is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@juliaElastic @jsoriano @cmacknz @jlind23 @michel-laterman