Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jun 6, 2025

See changelog for 1.24.4


Bump golang-version to latest version

Update .go-version

1 file(s) updated with "1.24.4": * .go-version

1.24.4
no GitHub Release found for go1.24.4 on "https://github.com/golang/go"
Update go/Makefile.common

1 file(s) updated with "1.24.4": * go/Makefile.common

1.24.4
no GitHub Release found for go1.24.4 on "https://github.com/golang/go"
GitHub Action workflow link
Updatecli logo

Created automatically by Updatecli

Options:

Most of Updatecli configuration is done via its manifest(s).

  • If you close this pull request, Updatecli will automatically reopen it, the next time it runs.
  • If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.

Feel free to report any issues at github.com/updatecli/updatecli.
If you find this tool useful, do not hesitate to star our GitHub repository as a sign of appreciation, and/or to tell us directly on our chat!

github-actions bot added 2 commits June 6, 2025 03:24
Made with ❤️️ by updatecli
Made with ❤️️ by updatecli
@elasticmachine
Copy link

💚 Build Succeeded

Copy link

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving mergify

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Jun 6, 2025
@mergify mergify bot merged commit 35c4d22 into main Jun 6, 2025
7 checks passed
@mergify mergify bot deleted the updatecli_main_bump-golang-version-main branch June 6, 2025 07:10
@pkoutsovasilis
Copy link
Contributor

Unfortunately something was missed in the github actions that prepared the bump for golang 1.24.4 and the respective Dockerfile.tmpl didn't bump to 1.24.4
link

✔ Bump golang-microsoft to latest version:
	Source:
		✔ [golangVersion] Get golang version
		✔ [latestGoVersion] Get Latest Go Release
		✔ [minor] Get minor version
		✔ [securityVersion] Get security version
	Condition:
		✔ [is-golang-available] Is version '1.24.3' available in 'go/base/Dockerfile.tmpl'?
		✗ [is-security-already-updated] Is security version '-1' not updated in 'go/base/Dockerfile.tmpl'?
	Target:
		- [update-go-versions] Update go version 1.24.3-1


✗ Bump golang-version to latest version:
	Source:
		✔ [latestGoVersion] Get Latest Go Release
		✔ [minor] Get minor version
	Condition:
		✔ [dockerTag] Is docker image golang:1.24.4 published
		✔ [is-already-updated] Is version '1.24.4' not updated in 'go/Makefile.common'?
	Target:
		⚠ [update-go-makefile.common] Update go/Makefile.common
		⚠ [update-go-version] Update .go-version
		✗ [update-go-versions] Update go version 1.24.4


Run Summary
===========
Pipeline(s) run:
  * Changed:	0
  * Failed:	1
  * Skipped:	0
  * Succeeded:	1
  * Total:	2

As a result this happened in the resulting container image

Digest: sha256:4bba3fd6f80b20c3b3fbbb62290323469a36362b1983d828067cb70be4a896fd
Status: Downloaded newer image for docker.elastic.co/beats-dev/golang-crossbuild:1.24.4-main-debian11
root@e5380624219f:/app# go version
go version go1.24.3 linux/amd64

cc @ebeahan @dliappis @v1v

@v1v
Copy link
Member

v1v commented Jun 8, 2025

Unfortunately something was missed in the github actions that prepared the bump for golang 1.24.4 and the respective Dockerfile.tmpl didn't bump to 1.24.4

I explored the topic further, and https://github.com/microsoft/go/releases/tag/v1.24.4-1 was released one day after the official release https://github.com/golang/go/releases/tag/go1.24.4

That's the reason

✗ [is-security-already-updated] Is security version '-1' not updated in 'go/base/Dockerfile.tmpl'?

did not pass the validation as there were no versions to compare with.

For now, I see there are three main areas of work:

  1. Fix the Golang version validation so that no promotion is made if a PR is created partially. See validate installed golang version and honour VERSION build-args #625
  2. Fix the Golang version for the golang-crossbuild version 1.24.4 and 1.23.x. See fix: 1.24.4 #626 and fix: 1.23.10 #627
  3. Fix the auto-bump to avoid these situations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants