Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge coverage per file and line #10315

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Jul 1, 2024

Merge coverage per file and line instead of just appending the content of each coverage result.

Possibly required for elastic/elastic-package#1915.

Merge coverage per file and line instead of just appending the content
of each coverage result.
@jsoriano jsoriano self-assigned this Jul 1, 2024
@jsoriano
Copy link
Member Author

jsoriano commented Jul 1, 2024

Testing this change also in #10273

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Probably, this could replace the sh script even if that other PR is not merged. This new golang dev tool does more checks when merging files (e.g. comparing covered lines too).

@jsoriano
Copy link
Member Author

jsoriano commented Jul 2, 2024

👍 Probably, this could replace the sh script even if that other PR is not merged. This new golang dev tool does more checks when merging files (e.g. comparing covered lines too).

Yes, we can merge this separatedly.

@jsoriano jsoriano marked this pull request as ready for review July 2, 2024 09:48
@jsoriano jsoriano requested a review from a team as a code owner July 2, 2024 09:48
@jsoriano jsoriano merged commit 647b31d into elastic:main Jul 2, 2024
4 of 5 checks passed
@jsoriano jsoriano deleted the merge-coverage branch July 2, 2024 09:51
@amitkanfer
Copy link
Contributor

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants