Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip ignored fields check for offending data streams II #9871

Closed

Conversation

flash1293
Copy link
Contributor

See #9823

This is adding the same config for a few other data streams that were missed

@flash1293 flash1293 added the bugfix Pull request that fixes a bug issue label May 15, 2024
@flash1293 flash1293 requested a review from a team as a code owner May 15, 2024 09:16
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@botelastic
Copy link

botelastic bot commented Jun 14, 2024

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jun 14, 2024
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wants a changelog entry.

@botelastic botelastic bot removed the Stalled label Jun 16, 2024
@flash1293
Copy link
Contributor Author

@efd6 This is purely a build-time change that doesn't affect the user, should it really get a changelog entry (which would imply a version bump by my understanding)?

I was under the impression that this kind of changes are merged without a release (also see #9823 )

@elasticmachine
Copy link

💚 Build Succeeded

History

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@jsoriano
Copy link
Member

jsoriano commented Jul 4, 2024

Changes merged as part of #10378, closing this. Thanks!

@jsoriano jsoriano closed this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants