Skip to content

Commit

Permalink
[8.15] Unskip Dashboard to TSVB to Lens should convert a by reference (
Browse files Browse the repository at this point in the history
…#190230) (#190353)

# Backport

This will backport the following commits from `main` to `8.15`:
- [Unskip Dashboard to TSVB to Lens should convert a by reference
(#190230)](#190230)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marta
Bondyra","email":"4283304+mbondyra@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-08-12T18:46:20Z","message":"Unskip
Dashboard to TSVB to Lens should convert a by reference (#190230)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/179307\r\n\r\nWhat I suspect
happening is that some 'ghost' click is somehow happening\r\noutside of
the panel settings area (that should be open the point where\r\ntests
breaks, but the screenshot shows it's closed) and that's why it
is\r\nclosed. Adding a retry around the whole panel settings actions
should\r\nhelp, but let's keep an eye on it.\r\n\r\n\r\n<img
width=\"1100\" alt=\"Screenshot 2024-08-09 at 13 44
20\"\r\nsrc=\"https://github.com/user-attachments/assets/17d61852-c371-453d-9f41-46fd52f9e384\">\r\n\r\nThe
flakiness is rare so not sure if running the flaky test runner
makes\r\nsense, but I'd do it
anyway:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6733","sha":"bb73fc41bd5cc2abb99479442e62148546c37fbb","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:TSVB","Team:Visualizations","release_note:skip","Feature:Lens","backport:prev-minor","v8.16.0","v8.15.1"],"title":"Unskip
Dashboard to TSVB to Lens should convert a by
reference","number":190230,"url":"https://github.com/elastic/kibana/pull/190230","mergeCommit":{"message":"Unskip
Dashboard to TSVB to Lens should convert a by reference (#190230)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/179307\r\n\r\nWhat I suspect
happening is that some 'ghost' click is somehow happening\r\noutside of
the panel settings area (that should be open the point where\r\ntests
breaks, but the screenshot shows it's closed) and that's why it
is\r\nclosed. Adding a retry around the whole panel settings actions
should\r\nhelp, but let's keep an eye on it.\r\n\r\n\r\n<img
width=\"1100\" alt=\"Screenshot 2024-08-09 at 13 44
20\"\r\nsrc=\"https://github.com/user-attachments/assets/17d61852-c371-453d-9f41-46fd52f9e384\">\r\n\r\nThe
flakiness is rare so not sure if running the flaky test runner
makes\r\nsense, but I'd do it
anyway:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6733","sha":"bb73fc41bd5cc2abb99479442e62148546c37fbb"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/190230","number":190230,"mergeCommit":{"message":"Unskip
Dashboard to TSVB to Lens should convert a by reference (#190230)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/179307\r\n\r\nWhat I suspect
happening is that some 'ghost' click is somehow happening\r\noutside of
the panel settings area (that should be open the point where\r\ntests
breaks, but the screenshot shows it's closed) and that's why it
is\r\nclosed. Adding a retry around the whole panel settings actions
should\r\nhelp, but let's keep an eye on it.\r\n\r\n\r\n<img
width=\"1100\" alt=\"Screenshot 2024-08-09 at 13 44
20\"\r\nsrc=\"https://github.com/user-attachments/assets/17d61852-c371-453d-9f41-46fd52f9e384\">\r\n\r\nThe
flakiness is rare so not sure if running the flaky test runner
makes\r\nsense, but I'd do it
anyway:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6733","sha":"bb73fc41bd5cc2abb99479442e62148546c37fbb"}},{"branch":"8.15","label":"v8.15.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>
  • Loading branch information
kibanamachine and mbondyra authored Aug 12, 2024
1 parent 040f646 commit 089d42b
Showing 1 changed file with 10 additions and 9 deletions.
19 changes: 10 additions & 9 deletions x-pack/test/functional/apps/lens/open_in_lens/tsvb/dashboard.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
const dashboardAddPanel = getService('dashboardAddPanel');
const filterBar = getService('filterBar');

// FLAKY: https://github.com/elastic/kibana/issues/179307
describe.skip('Dashboard to TSVB to Lens', function describeIndexTests() {
describe('Dashboard to TSVB to Lens', function describeIndexTests() {
before(async () => {
await visualize.initTests();
});
Expand Down Expand Up @@ -90,13 +89,15 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {

await dashboard.waitForRenderComplete();
const originalEmbeddableCount = await canvas.getEmbeddableCount();
await dashboardPanelActions.customizePanel();
await dashboardCustomizePanel.enableCustomTimeRange();
await dashboardCustomizePanel.openDatePickerQuickMenu();
await dashboardCustomizePanel.clickCommonlyUsedTimeRange('Last_30 days');
await dashboardCustomizePanel.clickSaveButton();
await dashboard.waitForRenderComplete();
await dashboardBadgeActions.expectExistsTimeRangeBadgeAction();
await retry.try(async () => {
await dashboardPanelActions.customizePanel();
await dashboardCustomizePanel.enableCustomTimeRange();
await dashboardCustomizePanel.openDatePickerQuickMenu();
await dashboardCustomizePanel.clickCommonlyUsedTimeRange('Last_30 days');
await dashboardCustomizePanel.clickSaveButton();
await dashboard.waitForRenderComplete();
await dashboardBadgeActions.expectExistsTimeRangeBadgeAction();
});
await panelActions.openContextMenu();
await panelActions.clickEdit();

Expand Down

0 comments on commit 089d42b

Please sign in to comment.