From 0d09335cb7ae43b15a12612f0a67ab0be3ec0a45 Mon Sep 17 00:00:00 2001
From: Gloria Hornero <snootchie.boochies@gmail.com>
Date: Wed, 2 Dec 2020 18:23:16 +0100
Subject: [PATCH] fixes alerts test

---
 .../cypress/integration/alerts.spec.ts        | 36 ++++++++-----------
 1 file changed, 15 insertions(+), 21 deletions(-)

diff --git a/x-pack/plugins/security_solution/cypress/integration/alerts.spec.ts b/x-pack/plugins/security_solution/cypress/integration/alerts.spec.ts
index 8e3b30cddd1215..0810babc9370bb 100644
--- a/x-pack/plugins/security_solution/cypress/integration/alerts.spec.ts
+++ b/x-pack/plugins/security_solution/cypress/integration/alerts.spec.ts
@@ -4,10 +4,10 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 import {
-  NUMBER_OF_ALERTS,
+  ALERTS,
+  ALERTS_COUNT,
   SELECTED_ALERTS,
   SHOWING_ALERTS,
-  ALERTS,
   TAKE_ACTION_POPOVER_BTN,
 } from '../screens/alerts';
 
@@ -45,7 +45,7 @@ describe('Alerts', () => {
       waitForAlertsPanelToBeLoaded();
       waitForAlertsToBeLoaded();
 
-      cy.get(NUMBER_OF_ALERTS)
+      cy.get(ALERTS_COUNT)
         .invoke('text')
         .then((numberOfAlerts) => {
           cy.get(SHOWING_ALERTS).should('have.text', `Showing ${numberOfAlerts} alerts`);
@@ -64,10 +64,7 @@ describe('Alerts', () => {
           waitForAlerts();
 
           const expectedNumberOfAlertsAfterClosing = +numberOfAlerts - numberOfAlertsToBeClosed;
-          cy.get(NUMBER_OF_ALERTS).should(
-            'have.text',
-            expectedNumberOfAlertsAfterClosing.toString()
-          );
+          cy.get(ALERTS_COUNT).should('have.text', expectedNumberOfAlertsAfterClosing.toString());
 
           cy.get(SHOWING_ALERTS).should(
             'have.text',
@@ -77,7 +74,7 @@ describe('Alerts', () => {
           goToClosedAlerts();
           waitForAlerts();
 
-          cy.get(NUMBER_OF_ALERTS).should('have.text', numberOfAlertsToBeClosed.toString());
+          cy.get(ALERTS_COUNT).should('have.text', numberOfAlertsToBeClosed.toString());
           cy.get(SHOWING_ALERTS).should(
             'have.text',
             `Showing ${numberOfAlertsToBeClosed.toString()} alerts`
@@ -98,7 +95,7 @@ describe('Alerts', () => {
           waitForAlerts();
 
           const expectedNumberOfClosedAlertsAfterOpened = 2;
-          cy.get(NUMBER_OF_ALERTS).should(
+          cy.get(ALERTS_COUNT).should(
             'have.text',
             expectedNumberOfClosedAlertsAfterOpened.toString()
           );
@@ -128,7 +125,7 @@ describe('Alerts', () => {
     it('Closes one alert when more than one opened alerts are selected', () => {
       waitForAlertsToBeLoaded();
 
-      cy.get(NUMBER_OF_ALERTS)
+      cy.get(ALERTS_COUNT)
         .invoke('text')
         .then((numberOfAlerts) => {
           const numberOfAlertsToBeClosed = 1;
@@ -144,7 +141,7 @@ describe('Alerts', () => {
           waitForAlerts();
 
           const expectedNumberOfAlerts = +numberOfAlerts - numberOfAlertsToBeClosed;
-          cy.get(NUMBER_OF_ALERTS).should('have.text', expectedNumberOfAlerts.toString());
+          cy.get(ALERTS_COUNT).should('have.text', expectedNumberOfAlerts.toString());
           cy.get(SHOWING_ALERTS).should(
             'have.text',
             `Showing ${expectedNumberOfAlerts.toString()} alerts`
@@ -153,7 +150,7 @@ describe('Alerts', () => {
           goToClosedAlerts();
           waitForAlerts();
 
-          cy.get(NUMBER_OF_ALERTS).should('have.text', numberOfAlertsToBeClosed.toString());
+          cy.get(ALERTS_COUNT).should('have.text', numberOfAlertsToBeClosed.toString());
           cy.get(SHOWING_ALERTS).should(
             'have.text',
             `Showing ${numberOfAlertsToBeClosed.toString()} alert`
@@ -178,7 +175,7 @@ describe('Alerts', () => {
       goToClosedAlerts();
       waitForAlertsToBeLoaded();
 
-      cy.get(NUMBER_OF_ALERTS)
+      cy.get(ALERTS_COUNT)
         .invoke('text')
         .then((numberOfAlerts) => {
           const numberOfAlertsToBeOpened = 1;
@@ -195,7 +192,7 @@ describe('Alerts', () => {
           waitForAlerts();
 
           const expectedNumberOfAlerts = +numberOfAlerts - numberOfAlertsToBeOpened;
-          cy.get(NUMBER_OF_ALERTS).should('have.text', expectedNumberOfAlerts.toString());
+          cy.get(ALERTS_COUNT).should('have.text', expectedNumberOfAlerts.toString());
           cy.get(SHOWING_ALERTS).should(
             'have.text',
             `Showing ${expectedNumberOfAlerts.toString()} alerts`
@@ -204,7 +201,7 @@ describe('Alerts', () => {
           goToOpenedAlerts();
           waitForAlerts();
 
-          cy.get(NUMBER_OF_ALERTS).should('have.text', numberOfAlertsToBeOpened.toString());
+          cy.get(ALERTS_COUNT).should('have.text', numberOfAlertsToBeOpened.toString());
           cy.get(SHOWING_ALERTS).should(
             'have.text',
             `Showing ${numberOfAlertsToBeOpened.toString()} alert`
@@ -228,7 +225,7 @@ describe('Alerts', () => {
       waitForAlerts();
       waitForAlertsToBeLoaded();
 
-      cy.get(NUMBER_OF_ALERTS)
+      cy.get(ALERTS_COUNT)
         .invoke('text')
         .then((numberOfAlerts) => {
           const numberOfAlertsToBeMarkedInProgress = 1;
@@ -244,7 +241,7 @@ describe('Alerts', () => {
           waitForAlertsToBeLoaded();
 
           const expectedNumberOfAlerts = +numberOfAlerts - numberOfAlertsToBeMarkedInProgress;
-          cy.get(NUMBER_OF_ALERTS).should('have.text', expectedNumberOfAlerts.toString());
+          cy.get(ALERTS_COUNT).should('have.text', expectedNumberOfAlerts.toString());
           cy.get(SHOWING_ALERTS).should(
             'have.text',
             `Showing ${expectedNumberOfAlerts.toString()} alerts`
@@ -253,10 +250,7 @@ describe('Alerts', () => {
           goToInProgressAlerts();
           waitForAlerts();
 
-          cy.get(NUMBER_OF_ALERTS).should(
-            'have.text',
-            numberOfAlertsToBeMarkedInProgress.toString()
-          );
+          cy.get(ALERTS_COUNT).should('have.text', numberOfAlertsToBeMarkedInProgress.toString());
           cy.get(SHOWING_ALERTS).should(
             'have.text',
             `Showing ${numberOfAlertsToBeMarkedInProgress.toString()} alert`