-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix serverless reporting API integration tests for MKI runs (#179330)
## Summary This PR fixes the serverless reporting API integration tests for MKI runs. ### The problem that we saw After #178159 was merged, we saw the `Reporting Generate CSV` API integration tests fail with `401` responses when running against MKI projects. It turned out that the tests were using hard-coded credentials that are only working locally / in CI - real serverless projects run with a different set of username and password. ### How this PR fixes it Remove hard-coded credentials from `x-pack/test_serverless/shared/services/svl_reporting.ts` and instead read them from the test config, which has the proper entries for local and MKI runs. I've also preemptively adjusted `x-pack/test_serverless/functional/services/svl_reporting.ts` and `x-pack/test_serverless/api_integration/test_suites/common/reporting/management.ts` in the same way even though they not run in MKI projects today. This will hopefully avoid the same set of problems when the tests eventually get re-enabled for MKI runs.
- Loading branch information
Showing
3 changed files
with
10 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters