Skip to content

Commit

Permalink
[Field Formats] Unskip field formats Serverless tests (#166409)
Browse files Browse the repository at this point in the history
## Summary

This PR unskips the field formats Serverless tests. I ran 100x flaky
test runs against each project type to confirm they should no longer be
flaky.

Flaky test runs:
- x100 (`.only`):
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3113
- x100 Search:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3120
- x100 O11y:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3146
- x100 Security:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3155

Resolves #165537.
Resolves #165545.

### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
  • Loading branch information
davismcphee authored Sep 19, 2023
1 parent 55d9058 commit 2234237
Showing 1 changed file with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,12 @@ import type { FtrProviderContext } from '../../../../ftr_provider_context';

export default function ({ getService, getPageObjects }: FtrProviderContext) {
const testSubjects = getService('testSubjects');
const PageObjects = getPageObjects(['common']);
const PageObjects = getPageObjects(['common', 'svlCommonPage']);

// Flaky in serverless tests
describe.skip('Field formats example', function () {
describe('Field formats example', function () {
before(async () => {
// TODO: Serverless tests require login first
await PageObjects.svlCommonPage.login();
await PageObjects.common.navigateToApp('fieldFormatsExample');
});

Expand Down

0 comments on commit 2234237

Please sign in to comment.