From 4a867a1952b2ed3b70843182060417b0c10bb729 Mon Sep 17 00:00:00 2001 From: Poff Poffenberger Date: Thu, 3 Oct 2019 09:28:37 -0500 Subject: [PATCH] [Canvas] i18n for page manager, page preview, and shape preview (#46865) * i18n for page manager, page preview, and shape preview * Addressing feedback * Forgot to remove ShapePreview --- .../legacy/plugins/canvas/i18n/components.ts | 27 +++++++++++++++++++ .../components/page_manager/page_manager.js | 6 ++++- .../components/page_preview/page_controls.js | 14 ++++++---- 3 files changed, 41 insertions(+), 6 deletions(-) diff --git a/x-pack/legacy/plugins/canvas/i18n/components.ts b/x-pack/legacy/plugins/canvas/i18n/components.ts index db62f43776f3c..d4b9b8310cbd3 100644 --- a/x-pack/legacy/plugins/canvas/i18n/components.ts +++ b/x-pack/legacy/plugins/canvas/i18n/components.ts @@ -214,6 +214,33 @@ export const ComponentStrings = { defaultMessage: 'Closes keyboard shortcuts reference', }), }, + PageManager: { + getPageNumberAriaLabel: (pageNumber: number) => + i18n.translate('xpack.canvas.pageManager.pageNumberAriaLabel', { + defaultMessage: 'Load page number {pageNumber}', + values: { + pageNumber, + }, + }), + }, + PagePreviewPageControls: { + getClonePageAriaLabel: () => + i18n.translate('xpack.canvas.pagePreviewPageControls.clonePageAriaLabel', { + defaultMessage: 'Clone page', + }), + getClonePageTooltip: () => + i18n.translate('xpack.canvas.pagePreviewPageControls.clonePageTooltip', { + defaultMessage: 'Clone', + }), + getDeletePageAriaLabel: () => + i18n.translate('xpack.canvas.pagePreviewPageControls.deletePageAriaLabel', { + defaultMessage: 'Delete page', + }), + getDeletePageTooltip: () => + i18n.translate('xpack.canvas.pagePreviewPageControls.deletePageTooltip', { + defaultMessage: 'Delete', + }), + }, Toolbar: { getEditorButtonLabel: () => i18n.translate('xpack.canvas.toolbar.editorButtonLabel', { diff --git a/x-pack/legacy/plugins/canvas/public/components/page_manager/page_manager.js b/x-pack/legacy/plugins/canvas/public/components/page_manager/page_manager.js index 533733f9aeacf..2208d7f363f5e 100644 --- a/x-pack/legacy/plugins/canvas/public/components/page_manager/page_manager.js +++ b/x-pack/legacy/plugins/canvas/public/components/page_manager/page_manager.js @@ -13,6 +13,10 @@ import { ConfirmModal } from '../confirm_modal'; import { Link } from '../link'; import { PagePreview } from '../page_preview'; +import { ComponentStrings } from '../../../i18n'; + +const { PageManager: strings } = ComponentStrings; + export class PageManager extends React.PureComponent { static propTypes = { isWriteable: PropTypes.bool.isRequired, @@ -154,7 +158,7 @@ export class PageManager extends React.PureComponent { {Style.it( workpadCSS, diff --git a/x-pack/legacy/plugins/canvas/public/components/page_preview/page_controls.js b/x-pack/legacy/plugins/canvas/public/components/page_preview/page_controls.js index 6cde599c79fa6..6c2030db5f2ca 100644 --- a/x-pack/legacy/plugins/canvas/public/components/page_preview/page_controls.js +++ b/x-pack/legacy/plugins/canvas/public/components/page_preview/page_controls.js @@ -8,6 +8,10 @@ import React from 'react'; import PropTypes from 'prop-types'; import { EuiFlexGroup, EuiFlexItem, EuiButtonIcon, EuiToolTip } from '@elastic/eui'; +import { ComponentStrings } from '../../../i18n'; + +const { PagePreviewPageControls: strings } = ComponentStrings; + export const PageControls = ({ pageId, onDelete, onDuplicate }) => { const handleDuplicate = ev => { ev.preventDefault(); @@ -26,20 +30,20 @@ export const PageControls = ({ pageId, onDelete, onDuplicate }) => { justifyContent="spaceBetween" > - + - +