Merge remote-tracking branch 'upstream/master' into 50395-refactor-lo…

…g-entries
elastic · Dec 9, 2019 · 550e485 · 550e485
2 parents 030cd5f + 77dca06
commit 550e485
Show file tree

Hide file tree

Showing 156 changed files with 2,451 additions and 829 deletions.
diff --git a/.i18nrc.json b/.i18nrc.json
@@ -17,6 +17,7 @@
     "kbn": "src/legacy/core_plugins/kibana",
     "kbnDocViews": "src/legacy/core_plugins/kbn_doc_views",
     "kbnVislibVisTypes": "src/legacy/core_plugins/kbn_vislib_vis_types",
+    "management": "src/legacy/core_plugins/management",
     "kibana_react": "src/legacy/core_plugins/kibana_react",
     "kibana-react": "src/plugins/kibana_react",
     "kibana_utils": "src/plugins/kibana_utils",

diff --git a/package.json b/package.json
@@ -113,7 +113,7 @@
     "@elastic/charts": "^14.0.0",
     "@elastic/datemath": "5.0.2",
     "@elastic/ems-client": "1.0.5",
-    "@elastic/eui": "16.1.0",
+    "@elastic/eui": "17.0.0",
     "@elastic/filesaver": "1.1.2",
     "@elastic/good": "8.1.1-kibana2",
     "@elastic/numeral": "2.3.3",
@@ -360,8 +360,8 @@
     "@types/uuid": "^3.4.4",
     "@types/vinyl-fs": "^2.4.11",
     "@types/zen-observable": "^0.8.0",
-    "@typescript-eslint/eslint-plugin": "^2.9.0",
-    "@typescript-eslint/parser": "^2.9.0",
+    "@typescript-eslint/eslint-plugin": "^2.10.0",
+    "@typescript-eslint/parser": "^2.10.0",
     "angular-mocks": "^1.7.8",
     "archiver": "^3.1.1",
     "axe-core": "^3.3.2",

diff --git a/packages/eslint-config-kibana/package.json b/packages/eslint-config-kibana/package.json
@@ -15,8 +15,8 @@
   },
   "homepage": "https://github.com/elastic/eslint-config-kibana#readme",
   "peerDependencies": {
-    "@typescript-eslint/eslint-plugin": "^2.9.0",
-    "@typescript-eslint/parser": "^2.9.0",
+    "@typescript-eslint/eslint-plugin": "^2.10.0",
+    "@typescript-eslint/parser": "^2.10.0",
     "babel-eslint": "^10.0.3",
     "eslint": "^6.5.1",
     "eslint-plugin-babel": "^5.3.0",

diff --git a/packages/kbn-ui-framework/dist/kui_dark.css b/packages/kbn-ui-framework/dist/kui_dark.css
@@ -1,10 +1,24 @@
+/* 1 */
+/* 1 */
+/**
+ * 1. Extend beta badges to at least 40% of the container's width
+ * 2. Fix for IE to ensure badges are visible outside of a <button> tag
+ */
+/**
+ * 1. Apply margin to all but last item in the flex.
+ * 2. Margin gets flipped because of the row-reverse.
+ */
 /**
- * 2. Account for inner box-shadow style border when in group
  * 3. Must supply both values to background-size or some browsers apply the single value to both directions
  */
 /**
  * 4. Override invalid state with focus state.
  */
+/**
+ *  Mixin for use in:
+ *  - EuiCard
+ *  - EuiPageContent
+*/
 /**
  * 1. Enforce pointer when there's no href.
  * 2. Allow these styles to be applied to a button element.
@@ -1595,7 +1609,6 @@ main {
   -webkit-align-items: center;
       -ms-flex-align: center;
           align-items: center;
-  height: 100%;
   padding: 12px 8px;
   font-size: 16px;
   font-weight: bold;

diff --git a/packages/kbn-ui-framework/dist/kui_light.css b/packages/kbn-ui-framework/dist/kui_light.css
@@ -1,10 +1,24 @@
+/* 1 */
+/* 1 */
+/**
+ * 1. Extend beta badges to at least 40% of the container's width
+ * 2. Fix for IE to ensure badges are visible outside of a <button> tag
+ */
+/**
+ * 1. Apply margin to all but last item in the flex.
+ * 2. Margin gets flipped because of the row-reverse.
+ */
 /**
- * 2. Account for inner box-shadow style border when in group
  * 3. Must supply both values to background-size or some browsers apply the single value to both directions
  */
 /**
  * 4. Override invalid state with focus state.
  */
+/**
+ *  Mixin for use in:
+ *  - EuiCard
+ *  - EuiPageContent
+*/
 /**
  * 1. Enforce pointer when there's no href.
  * 2. Allow these styles to be applied to a button element.
@@ -522,7 +536,7 @@ main {
   -webkit-appearance: none;
   /* 1 */
   background-color: #fbfcfd;
-  border: 1px solid rgba(0, 0, 0, 0.1);
+  border: 1px solid rgba(15, 39, 118, 0.1);
   border-radius: 4px;
   width: 16px;
   height: 16px;
@@ -623,7 +637,7 @@ main {
   line-height: 1.5;
   color: #343741;
   background-color: #fbfcfd;
-  border: 1px solid rgba(0, 0, 0, 0.1);
+  border: 1px solid rgba(15, 39, 118, 0.1);
   border-radius: 4px;
   -webkit-transition: border-color 0.1s linear;
   transition: border-color 0.1s linear;
@@ -662,7 +676,7 @@ main {
   line-height: 1.5;
   color: #343741;
   background-color: #fbfcfd;
-  border: 1px solid rgba(0, 0, 0, 0.1);
+  border: 1px solid rgba(15, 39, 118, 0.1);
   border-radius: 4px;
   -webkit-transition: border-color 0.1s linear;
   transition: border-color 0.1s linear;
@@ -734,7 +748,7 @@ main {
   line-height: 1.5;
   color: #343741;
   background-color: #fbfcfd;
-  border: 1px solid rgba(0, 0, 0, 0.1);
+  border: 1px solid rgba(15, 39, 118, 0.1);
   border-radius: 4px;
   -webkit-transition: border-color 0.1s linear;
   transition: border-color 0.1s linear;
@@ -777,7 +791,7 @@ main {
   line-height: 1.5;
   color: #343741;
   background-color: #fbfcfd;
-  border: 1px solid rgba(0, 0, 0, 0.1);
+  border: 1px solid rgba(15, 39, 118, 0.1);
   border-radius: 4px;
   -webkit-transition: border-color 0.1s linear;
   transition: border-color 0.1s linear;
@@ -1252,7 +1266,7 @@ main {
   font-size: 14px;
   color: #343741;
   background-color: #fbfcfd;
-  border: 1px solid rgba(0, 0, 0, 0.1);
+  border: 1px solid rgba(15, 39, 118, 0.1);
   border-radius: 4px; }
   .kuiLocalDropdownInput:focus {
     border-color: #006BB4; }
@@ -1410,7 +1424,7 @@ main {
   line-height: 1.5;
   color: #343741;
   background-color: #fbfcfd;
-  border: 1px solid rgba(0, 0, 0, 0.1);
+  border: 1px solid rgba(15, 39, 118, 0.1);
   border-radius: 4px;
   -webkit-transition: border-color 0.1s linear;
   transition: border-color 0.1s linear;
@@ -1491,7 +1505,7 @@ main {
   line-height: 1.5;
   color: #343741;
   background-color: #fbfcfd;
-  border: 1px solid rgba(0, 0, 0, 0.1);
+  border: 1px solid rgba(15, 39, 118, 0.1);
   border-radius: 4px;
   -webkit-transition: border-color 0.1s linear;
   transition: border-color 0.1s linear;
@@ -1595,7 +1609,6 @@ main {
   -webkit-align-items: center;
       -ms-flex-align: center;
           align-items: center;
-  height: 100%;
   padding: 12px 8px;
   font-size: 16px;
   font-weight: bold;

diff --git a/packages/kbn-ui-framework/src/kui_dark.scss b/packages/kbn-ui-framework/src/kui_dark.scss
@@ -3,8 +3,6 @@
 @import '../../../node_modules/@elastic/eui/src/global_styling/functions/index';
 @import '../../../node_modules/@elastic/eui/src/global_styling/variables/index';
 @import '../../../node_modules/@elastic/eui/src/global_styling/mixins/index';
-@import '../../../node_modules/@elastic/eui/src/components/form/variables';
-@import '../../../node_modules/@elastic/eui/src/components/form/mixins';
 
 // Configuration
 @import 'global_styling/variables/index';

diff --git a/packages/kbn-ui-framework/src/kui_light.scss b/packages/kbn-ui-framework/src/kui_light.scss
@@ -3,8 +3,6 @@
 @import '../../../node_modules/@elastic/eui/src/global_styling/functions/index';
 @import '../../../node_modules/@elastic/eui/src/global_styling/variables/index';
 @import '../../../node_modules/@elastic/eui/src/global_styling/mixins/index';
-@import '../../../node_modules/@elastic/eui/src/components/form/variables';
-@import '../../../node_modules/@elastic/eui/src/components/form/mixins';
 
 // Configuration
 @import 'global_styling/variables/index';

diff --git a/src/core/MIGRATION.md b/src/core/MIGRATION.md
@@ -1193,7 +1193,7 @@ import { setup, start } from '../core_plugins/visualizations/public/legacy';
 
 | Legacy Platform                                   | New Platform                                                 | Notes                                                                                                                                                        |
 | ------------------------------------------------- | ------------------------------------------------------------ | ------------------------------------------------------------------------------------------------------------------------------------------------------------ |
-| `import 'ui/apply_filters'`                       | `import { applyFiltersPopover } from '../data/public'`       | Directive is deprecated.                                                                                 |
+| `import 'ui/apply_filters'`                       | N/A. Replaced by triggering an APPLY_FILTER_TRIGGER trigger.       | Directive is deprecated.                                                                                 |
 | `import 'ui/filter_bar'`                          | `import { FilterBar } from '../data/public'`                 | Directive is deprecated.                                                                                   |
 | `import 'ui/query_bar'`                           | `import { QueryStringInput } from '../data/public'`          | Directives are deprecated.                                                                                                                                             |
 | `import 'ui/search_bar'`                          | `import { SearchBar } from '../data/public'`                 | Directive is deprecated.                                                                                                                                     |

diff --git a/src/core/public/chrome/constants.ts b/src/core/public/chrome/constants.ts
@@ -17,6 +17,8 @@
  * under the License.
  */
 
-export const KIBANA_FEEDBACK_LINK = 'https://www.elastic.co/products/kibana/feedback';
-export const KIBANA_ASK_ELASTIC_LINK = 'https://www.elastic.co/products/kibana/ask-elastic';
+export const KIBANA_FEEDBACK_LINK =
+  'https://www.elastic.co/products/kibana/feedback?blade=kibanafeedback';
+export const KIBANA_ASK_ELASTIC_LINK =
+  'https://www.elastic.co/products/kibana/ask-elastic?blade=kibanaaskelastic';
 export const GITHUB_CREATE_ISSUE_LINK = 'https://github.com/elastic/kibana/issues/new/choose';
diff --git a/src/legacy/core_plugins/data/public/legacy.ts b/src/legacy/core_plugins/data/public/legacy.ts
@@ -43,5 +43,4 @@ export const setup = dataPlugin.setup(npSetup.core);
 
 export const start = dataPlugin.start(npStart.core, {
   data: npStart.plugins.data,
-  uiActions: npSetup.plugins.uiActions,
 });
diff --git a/src/legacy/core_plugins/data/public/plugin.ts b/src/legacy/core_plugins/data/public/plugin.ts
@@ -22,19 +22,12 @@ import { createSearchBar, StatetfulSearchBarProps } from './search';
 import { Storage, IStorageWrapper } from '../../../../../src/plugins/kibana_utils/public';
 import { DataPublicPluginStart } from '../../../../plugins/data/public';
 import { initLegacyModule } from './shim/legacy_module';
-import { IUiActionsSetup } from '../../../../plugins/ui_actions/public';
-import {
-  createFilterAction,
-  GLOBAL_APPLY_FILTER_ACTION,
-} from './filter/action/apply_filter_action';
-import { APPLY_FILTER_TRIGGER } from '../../../../plugins/embeddable/public';
 
 // eslint-disable-next-line @kbn/eslint/no-restricted-paths
 import { setFieldFormats } from '../../../../plugins/data/public/services';
 
 export interface DataPluginStartDependencies {
   data: DataPublicPluginStart;
-  uiActions: IUiActionsSetup;
 }
 
 /**
@@ -67,7 +60,7 @@ export class DataPlugin implements Plugin<void, DataStart, {}, DataPluginStartDe
     this.storage = new Storage(window.localStorage);
   }
 
-  public start(core: CoreStart, { data, uiActions }: DataPluginStartDependencies): DataStart {
+  public start(core: CoreStart, { data }: DataPluginStartDependencies): DataStart {
     // This is required for when Angular code uses Field and FieldList.
     setFieldFormats(data.fieldFormats);
     initLegacyModule(data.indexPatterns);
@@ -78,17 +71,6 @@ export class DataPlugin implements Plugin<void, DataStart, {}, DataPluginStartDe
       storage: this.storage,
     });
 
-    uiActions.registerAction(
-      createFilterAction(
-        core.overlays,
-        data.query.filterManager,
-        data.query.timefilter.timefilter,
-        data.indexPatterns
-      )
-    );
-
-    uiActions.attachAction(APPLY_FILTER_TRIGGER, GLOBAL_APPLY_FILTER_ACTION);
-
     return {
       ui: {
         SearchBar,

diff --git a/src/legacy/core_plugins/kibana/public/discover/_discover.scss b/src/legacy/core_plugins/kibana/public/discover/_discover.scss
@@ -1,5 +1,3 @@
-@import 'node_modules/@elastic/eui/src/components/panel/mixins';
-
 discover-app {
   flex-grow: 1;
 
@@ -37,7 +35,7 @@ discover-app {
   z-index: 1;
 }
 
-@include euiPanel('dscWrapper__content');
+@include euiPanel('.dscWrapper__content');
 
 .dscWrapper__content {
   padding-top: $euiSizeXS;
@@ -213,7 +211,6 @@ discover-app {
 }
 
 .dscResults {
-
   h3 {
     margin: -20px 0 10px 0;
     text-align: center;

diff --git a/src/legacy/core_plugins/kibana/public/index.scss b/src/legacy/core_plugins/kibana/public/index.scss
@@ -1,8 +1,6 @@
 @import 'src/legacy/ui/public/styles/styling_constants';
 
 // Elastic charts
-@import '@elastic/eui/src/components/tool_tip/variables';
-@import '@elastic/eui/src/components/tool_tip/mixins';
 @import '@elastic/charts/dist/theme';
 @import '@elastic/eui/src/themes/charts/theme';
 

diff --git a/.../index_patterns/create_index_pattern_wizard/components/step_time_field/step_time_field.js b/.../index_patterns/create_index_pattern_wizard/components/step_time_field/step_time_field.js
@@ -50,8 +50,6 @@ export class StepTimeField extends Component {
   constructor(props) {
     super(props);
 
-    const { getIndexPatternType, getIndexPatternName } = props.indexPatternCreationType;
-
     this.state = {
       error: '',
       timeFields: [],
@@ -61,8 +59,8 @@ export class StepTimeField extends Component {
       isFetchingTimeFields: false,
       isCreating: false,
       indexPatternId: '',
-      indexPatternType: getIndexPatternType(),
-      indexPatternName: getIndexPatternName(),
+      indexPatternType: props.indexPatternCreationType.getIndexPatternType(),
+      indexPatternName: props.indexPatternCreationType.getIndexPatternName(),
     };
   }
 

diff --git a/...ins/kibana/public/management/sections/index_patterns/create_index_pattern_wizard/index.js b/...ins/kibana/public/management/sections/index_patterns/create_index_pattern_wizard/index.js
@@ -21,7 +21,7 @@ import { SavedObjectsClientProvider } from 'ui/saved_objects';
 import uiRoutes from 'ui/routes';
 import angularTemplate from './angular_template.html';
 import 'ui/index_patterns';
-import { IndexPatternCreationFactory } from 'ui/management/index_pattern_creation';
+import { setup as managementSetup } from '../../../../../../management/public/legacy';
 import { getCreateBreadcrumbs } from '../breadcrumbs';
 
 import { renderCreateIndexPatternWizard, destroyCreateIndexPatternWizard } from './render';
@@ -35,8 +35,9 @@ uiRoutes.when('/management/kibana/index_pattern', {
     const Private = $injector.get('Private');
     $scope.$$postDigest(() => {
       const $routeParams = $injector.get('$routeParams');
-      const indexPatternCreationProvider = Private(IndexPatternCreationFactory)($routeParams.type);
-      const indexPatternCreationType = indexPatternCreationProvider.getType();
+      const indexPatternCreationType = managementSetup.indexPattern.creation.getType(
+        $routeParams.type
+      );
       const services = {
         config: $injector.get('config'),
         es: $injector.get('es'),
@@ -52,12 +53,9 @@ uiRoutes.when('/management/kibana/index_pattern', {
 
       const initialQuery = $routeParams.id ? decodeURIComponent($routeParams.id) : undefined;
 
-      renderCreateIndexPatternWizard(
-        initialQuery,
-        services
-      );
+      renderCreateIndexPatternWizard(initialQuery, services);
     });
 
     $scope.$on('$destroy', destroyCreateIndexPatternWizard);
-  }
+  },
 });