Merge remote-tracking branch 'upstream/master' into kbn-99211-fix-rei…

…ndex-race
elastic · Jul 6, 2021 · 641e63e · 641e63e
2 parents a4ca9dc + d5ca242
commit 641e63e
Show file tree

Hide file tree

Showing 298 changed files with 16,986 additions and 2,153 deletions.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -252,6 +252,7 @@
 /src/core/server/csp/  @elastic/kibana-security @elastic/kibana-core
 /src/plugins/security_oss/ @elastic/kibana-security
 /src/plugins/spaces_oss/ @elastic/kibana-security
+/src/plugins/user_setup/ @elastic/kibana-security
 /test/security_functional/ @elastic/kibana-security
 /x-pack/plugins/spaces/  @elastic/kibana-security
 /x-pack/plugins/encrypted_saved_objects/  @elastic/kibana-security

diff --git a/docs/developer/plugin-list.asciidoc b/docs/developer/plugin-list.asciidoc
@@ -256,6 +256,10 @@ In general this plugin provides:
 |The Usage Collection Service defines a set of APIs for other plugins to report the usage of their features. At the same time, it provides necessary the APIs for other services (i.e.: telemetry, monitoring, ...) to consume that usage data.
 
 
+|{kib-repo}blob/{branch}/src/plugins/user_setup/README.md[userSetup]
+|The plugin provides UI and APIs for the interactive setup mode.
+
+
 |{kib-repo}blob/{branch}/src/plugins/vis_default_editor/README.md[visDefaultEditor]
 |The default editor is used in most primary visualizations, e.x. Area, Data table, Pie, etc.
 It acts as a container for a particular visualization and options tabs. Contains the default "Data" tab in public/components/sidebar/data_tab.tsx.

diff --git a/...eddable/public/kibana-plugin-plugins-embeddable-public.embeddableeditorstate.md b/...eddable/public/kibana-plugin-plugins-embeddable-public.embeddableeditorstate.md
@@ -18,5 +18,6 @@ export interface EmbeddableEditorState
 |  --- | --- | --- |
 |  [embeddableId](./kibana-plugin-plugins-embeddable-public.embeddableeditorstate.embeddableid.md) | <code>string</code> |  |
 |  [originatingApp](./kibana-plugin-plugins-embeddable-public.embeddableeditorstate.originatingapp.md) | <code>string</code> |  |
+|  [searchSessionId](./kibana-plugin-plugins-embeddable-public.embeddableeditorstate.searchsessionid.md) | <code>string</code> | Pass current search session id when navigating to an editor, Editors could use it continue previous search session |
 |  [valueInput](./kibana-plugin-plugins-embeddable-public.embeddableeditorstate.valueinput.md) | <code>EmbeddableInput</code> |  |
 
diff --git a/...ibana-plugin-plugins-embeddable-public.embeddableeditorstate.searchsessionid.md b/...ibana-plugin-plugins-embeddable-public.embeddableeditorstate.searchsessionid.md
@@ -0,0 +1,13 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-plugins-embeddable-public](./kibana-plugin-plugins-embeddable-public.md) &gt; [EmbeddableEditorState](./kibana-plugin-plugins-embeddable-public.embeddableeditorstate.md) &gt; [searchSessionId](./kibana-plugin-plugins-embeddable-public.embeddableeditorstate.searchsessionid.md)
+
+## EmbeddableEditorState.searchSessionId property
+
+Pass current search session id when navigating to an editor, Editors could use it continue previous search session
+
+<b>Signature:</b>
+
+```typescript
+searchSessionId?: string;
+```
diff --git a/...ddable/public/kibana-plugin-plugins-embeddable-public.embeddablepackagestate.md b/...ddable/public/kibana-plugin-plugins-embeddable-public.embeddablepackagestate.md
@@ -18,5 +18,6 @@ export interface EmbeddablePackageState
 |  --- | --- | --- |
 |  [embeddableId](./kibana-plugin-plugins-embeddable-public.embeddablepackagestate.embeddableid.md) | <code>string</code> |  |
 |  [input](./kibana-plugin-plugins-embeddable-public.embeddablepackagestate.input.md) | <code>Optional&lt;EmbeddableInput, 'id'&gt; &#124; Optional&lt;SavedObjectEmbeddableInput, 'id'&gt;</code> |  |
+|  [searchSessionId](./kibana-plugin-plugins-embeddable-public.embeddablepackagestate.searchsessionid.md) | <code>string</code> | Pass current search session id when navigating to an editor, Editors could use it continue previous search session |
 |  [type](./kibana-plugin-plugins-embeddable-public.embeddablepackagestate.type.md) | <code>string</code> |  |
 
diff --git a/...bana-plugin-plugins-embeddable-public.embeddablepackagestate.searchsessionid.md b/...bana-plugin-plugins-embeddable-public.embeddablepackagestate.searchsessionid.md
@@ -0,0 +1,13 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-plugins-embeddable-public](./kibana-plugin-plugins-embeddable-public.md) &gt; [EmbeddablePackageState](./kibana-plugin-plugins-embeddable-public.embeddablepackagestate.md) &gt; [searchSessionId](./kibana-plugin-plugins-embeddable-public.embeddablepackagestate.searchsessionid.md)
+
+## EmbeddablePackageState.searchSessionId property
+
+Pass current search session id when navigating to an editor, Editors could use it continue previous search session
+
+<b>Signature:</b>
+
+```typescript
+searchSessionId?: string;
+```
diff --git a/docs/getting-started/quick-start-guide.asciidoc b/docs/getting-started/quick-start-guide.asciidoc
@@ -143,3 +143,6 @@ If you are you ready to add your own data, refer to <<connect-to-elasticsearch,A
 If you want to ingest your data, refer to {fleet-guide}/fleet-quick-start.html[Quick start: Get logs and metrics into the Elastic Stack].
 
 If you want to secure access to your data, refer to our guide on <<tutorial-secure-access-to-kibana, securing {kib}>>
+
+If you want to try out {ml-features} with the sample data sets, refer to
+{ml-docs}/ml-getting-started.html[Getting started with {ml}].
diff --git a/docs/user/ml/index.asciidoc b/docs/user/ml/index.asciidoc
@@ -80,7 +80,7 @@ browser so that it does not block pop-up windows or create an exception for your
 
 For more information about the {anomaly-detect} feature, see
 https://www.elastic.co/what-is/elastic-stack-machine-learning[{ml-cap} in the {stack}]
-and {ml-docs}/xpack-ml.html[{ml-cap} {anomaly-detect}].
+and {ml-docs}/ml-ad-overview.html[{ml-cap} {anomaly-detect}].
 
 [[xpack-ml-dfanalytics]]
 == {dfanalytics-cap}

diff --git a/docs/user/security/authentication/index.asciidoc b/docs/user/security/authentication/index.asciidoc
@@ -65,6 +65,10 @@ image::user/security/images/kibana-login.png["Login Selector UI"]
 
 For more information, refer to <<authentication-security-settings, authentication security settings>>.
 
+TIP: If you have multiple authentication providers configured, you can use the `auth_provider_hint` URL query parameter to create a deep
+link to any provider and bypass the Login Selector UI. Using the `kibana.yml` above as an example, you can add `?auth_provider_hint=basic1`
+to the login page URL, which will take you directly to the basic login page.
+
 [[basic-authentication]]
 ==== Basic authentication
 

diff --git a/examples/locator_explorer/public/app.tsx b/examples/locator_explorer/public/app.tsx
@@ -19,7 +19,7 @@ import { EuiFieldText } from '@elastic/eui';
 import { EuiPageHeader } from '@elastic/eui';
 import { EuiLink } from '@elastic/eui';
 import { AppMountParameters } from '../../../src/core/public';
-import { SharePluginSetup } from '../../../src/plugins/share/public';
+import { formatSearchParams, SharePluginSetup } from '../../../src/plugins/share/public';
 import {
   HelloLocatorV1Params,
   HelloLocatorV2Params,
@@ -34,6 +34,7 @@ interface MigratedLink {
   linkText: string;
   link: string;
   version: string;
+  params: HelloLocatorV1Params | HelloLocatorV2Params;
 }
 
 const ActionsExplorer = ({ share }: Props) => {
@@ -93,6 +94,7 @@ const ActionsExplorer = ({ share }: Props) => {
             linkText: savedLink.linkText,
             link,
             version: savedLink.version,
+            params: savedLink.params,
           } as MigratedLink;
         })
       );
@@ -157,7 +159,24 @@ const ActionsExplorer = ({ share }: Props) => {
                     target="_blank"
                   >
                     {link.linkText}
+                  </EuiLink>{' '}
+                  (
+                  <EuiLink
+                    color={link.version !== '0.0.2' ? 'danger' : 'primary'}
+                    data-test-subj="linkToHelloPage"
+                    href={
+                      '/app/r?' +
+                      formatSearchParams({
+                        id: 'HELLO_LOCATOR',
+                        version: link.version,
+                        params: link.params,
+                      }).toString()
+                    }
+                    target="_blank"
+                  >
+                    through redirect app
                   </EuiLink>
+                  )
                   <br />
                 </React.Fragment>
               ))

diff --git a/packages/kbn-dev-utils/src/certs.ts b/packages/kbn-dev-utils/src/certs.ts
@@ -8,7 +8,7 @@
 
 import { resolve } from 'path';
 
-export const CA_CERT_PATH = resolve(__dirname, '../certs/ca.crt');
+export const CA_CERT_PATH = process.env.TEST_CA_CERT_PATH || resolve(__dirname, '../certs/ca.crt');
 export const ES_KEY_PATH = resolve(__dirname, '../certs/elasticsearch.key');
 export const ES_CERT_PATH = resolve(__dirname, '../certs/elasticsearch.crt');
 export const ES_P12_PATH = resolve(__dirname, '../certs/elasticsearch.p12');

diff --git a/packages/kbn-optimizer/limits.yml b/packages/kbn-optimizer/limits.yml
@@ -112,3 +112,4 @@ pageLoadAssetSize:
   visTypePie: 35583
   expressionRevealImage: 25675
   cases: 144442
+  userSetup: 18532
diff --git a/src/core/public/doc_links/doc_links_service.ts b/src/core/public/doc_links/doc_links_service.ts
@@ -231,7 +231,7 @@ export class DocLinksService {
         ml: {
           guide: `${ELASTIC_WEBSITE_URL}guide/en/machine-learning/${DOC_LINK_VERSION}/index.html`,
           aggregations: `${ELASTIC_WEBSITE_URL}guide/en/machine-learning/${DOC_LINK_VERSION}/ml-configuring-aggregation.html`,
-          anomalyDetection: `${ELASTIC_WEBSITE_URL}guide/en/machine-learning/${DOC_LINK_VERSION}/xpack-ml.html`,
+          anomalyDetection: `${ELASTIC_WEBSITE_URL}guide/en/machine-learning/${DOC_LINK_VERSION}/ml-ad-overview.html`,
           anomalyDetectionJobs: `${ELASTIC_WEBSITE_URL}guide/en/machine-learning/${DOC_LINK_VERSION}/ml-jobs.html`,
           anomalyDetectionConfiguringCategories: `${ELASTIC_WEBSITE_URL}guide/en/machine-learning/${DOC_LINK_VERSION}/ml-configuring-categories.html`,
           anomalyDetectionBucketSpan: `${ELASTIC_WEBSITE_URL}guide/en/machine-learning/${DOC_LINK_VERSION}/create-jobs.html#bucket-span`,
@@ -249,7 +249,7 @@ export class DocLinksService {
           customUrls: `${ELASTIC_WEBSITE_URL}guide/en/machine-learning/${DOC_LINK_VERSION}/ml-configuring-url.html`,
           dataFrameAnalytics: `${ELASTIC_WEBSITE_URL}guide/en/machine-learning/${DOC_LINK_VERSION}/ml-dfanalytics.html`,
           featureImportance: `${ELASTIC_WEBSITE_URL}guide/en/machine-learning/${DOC_LINK_VERSION}/ml-feature-importance.html`,
-          outlierDetectionRoc: `${ELASTIC_WEBSITE_URL}guide/en/machine-learning/${DOC_LINK_VERSION}/ml-dfanalytics-evaluate.html#ml-dfanalytics-roc`,
+          outlierDetectionRoc: `${ELASTIC_WEBSITE_URL}guide/en/machine-learning/${DOC_LINK_VERSION}/ml-dfa-finding-outliers.html#ml-dfanalytics-roc`,
           regressionEvaluation: `${ELASTIC_WEBSITE_URL}guide/en/machine-learning/${DOC_LINK_VERSION}/ml-dfanalytics-evaluate.html#ml-dfanalytics-regression-evaluation`,
           classificationAucRoc: `${ELASTIC_WEBSITE_URL}guide/en/machine-learning/${DOC_LINK_VERSION}/ml-dfanalytics-evaluate.html#ml-dfanalytics-class-aucroc`,
         },

diff --git a/src/core/public/http/fetch.ts b/src/core/public/http/fetch.ts
@@ -30,6 +30,7 @@ interface Params {
 
 const JSON_CONTENT = /^(application\/(json|x-javascript)|text\/(x-)?javascript|x-json)(;.*)?$/;
 const NDJSON_CONTENT = /^(application\/ndjson)(;.*)?$/;
+const ZIP_CONTENT = /^(application\/zip)(;.*)?$/;
 
 const removedUndefined = (obj: Record<string, any> | undefined) => {
   return omitBy(obj, (v) => v === undefined);
@@ -153,7 +154,7 @@ export class Fetch {
     const contentType = response.headers.get('Content-Type') || '';
 
     try {
-      if (NDJSON_CONTENT.test(contentType)) {
+      if (NDJSON_CONTENT.test(contentType) || ZIP_CONTENT.test(contentType)) {
         body = await response.blob();
       } else if (JSON_CONTENT.test(contentType)) {
         body = await response.json();

diff --git a/src/plugins/dashboard/public/application/dashboard_app.tsx b/src/plugins/dashboard/public/application/dashboard_app.tsx
@@ -40,6 +40,7 @@ export function DashboardApp({
     embeddable,
     onAppLeave,
     uiSettings,
+    data,
   } = useKibana<DashboardAppServices>().services;
 
   const kbnUrlStateStorage = useMemo(
@@ -98,6 +99,13 @@ export function DashboardApp({
     ]);
   }, [chrome, dashboardState.title, dashboardState.viewMode, redirectTo, savedDashboardId]);
 
+  // clear search session when leaving dashboard route
+  useEffect(() => {
+    return () => {
+      data.search.session.clear();
+    };
+  }, [data.search.session]);
+
   return (
     <>
       {isCompleteDashboardAppState(dashboardAppState) && (

diff --git a/src/plugins/dashboard/public/application/dashboard_router.tsx b/src/plugins/dashboard/public/application/dashboard_router.tsx
@@ -260,6 +260,7 @@ export async function mountApp({
   }
   render(app, element);
   return () => {
+    dataStart.search.session.clear();
     unlistenParentHistory();
     unmountComponentAtNode(element);
     appUnMounted();

diff --git a/src/plugins/dashboard/public/application/lib/build_dashboard_container.ts b/src/plugins/dashboard/public/application/lib/build_dashboard_container.ts
@@ -64,6 +64,11 @@ export const buildDashboardContainer = async ({
     getLatestDashboardState,
     canStoreSearchSession: dashboardCapabilities.storeSearchSession,
   });
+
+  if (incomingEmbeddable?.searchSessionId) {
+    session.continue(incomingEmbeddable?.searchSessionId);
+  }
+
   const searchSessionIdFromURL = getSearchSessionIdFromURL(history);
   if (searchSessionIdFromURL) {
     session.restore(searchSessionIdFromURL);

diff --git a/src/plugins/dashboard/public/application/listing/dashboard_listing.tsx b/src/plugins/dashboard/public/application/listing/dashboard_listing.tsx
@@ -87,11 +87,6 @@ export const DashboardListing = ({
     };
   }, [title, savedObjectsClient, redirectTo, data.query, kbnUrlStateStorage]);
 
-  // clear dangling session because they are not required here
-  useEffect(() => {
-    data.search.session.clear();
-  }, [data.search.session]);
-
   const hideWriteControls = dashboardCapabilities.hideWriteControls;
   const listingLimit = savedObjects.settings.getListingLimit();
   const defaultFilter = title ? `"${title}"` : '';

diff --git a/src/plugins/dashboard/public/application/top_nav/dashboard_top_nav.tsx b/src/plugins/dashboard/public/application/top_nav/dashboard_top_nav.tsx
@@ -204,10 +204,11 @@ export function DashboardTopNav({
         path,
         state: {
           originatingApp: DashboardConstants.DASHBOARDS_ID,
+          searchSessionId: data.search.session.getSessionId(),
         },
       });
     },
-    [trackUiMetric, stateTransferService]
+    [stateTransferService, data.search.session, trackUiMetric]
   );
 
   const clearAddPanel = useCallback(() => {

diff --git a/src/plugins/data/public/public.api.md b/src/plugins/data/public/public.api.md
@@ -2783,7 +2783,7 @@ export interface WaitUntilNextSessionCompletesOptions {
 // src/plugins/data/public/index.ts:433:1 - (ae-forgotten-export) The symbol "propFilter" needs to be exported by the entry point index.d.ts
 // src/plugins/data/public/index.ts:436:1 - (ae-forgotten-export) The symbol "toAbsoluteDates" needs to be exported by the entry point index.d.ts
 // src/plugins/data/public/query/state_sync/connect_to_query_state.ts:34:5 - (ae-forgotten-export) The symbol "FilterStateStore" needs to be exported by the entry point index.d.ts
-// src/plugins/data/public/search/session/session_service.ts:56:5 - (ae-forgotten-export) The symbol "UrlGeneratorStateMapping" needs to be exported by the entry point index.d.ts
+// src/plugins/data/public/search/session/session_service.ts:62:5 - (ae-forgotten-export) The symbol "UrlGeneratorStateMapping" needs to be exported by the entry point index.d.ts
 
 // (No @packageDocumentation comment for this package)
 

diff --git a/src/plugins/data/public/search/session/mocks.ts b/src/plugins/data/public/search/session/mocks.ts
@@ -47,5 +47,6 @@ export function getSessionServiceMock(): jest.Mocked<ISessionService> {
     isSessionStorageReady: jest.fn(() => true),
     getSearchSessionIndicatorUiConfig: jest.fn(() => ({ isDisabled: () => ({ disabled: false }) })),
     hasAccess: jest.fn(() => true),
+    continue: jest.fn(),
   };
 }
diff --git a/src/plugins/data/public/search/session/session_service.test.ts b/src/plugins/data/public/search/session/session_service.test.ts
@@ -98,12 +98,12 @@ describe('Session service', () => {
       expect(nowProvider.reset).toHaveBeenCalled();
     });
 
-    it("Can clear other apps' session", async () => {
+    it("Can't clear other apps' session", async () => {
       sessionService.start();
       expect(sessionService.getSessionId()).not.toBeUndefined();
       currentAppId$.next('change');
       sessionService.clear();
-      expect(sessionService.getSessionId()).toBeUndefined();
+      expect(sessionService.getSessionId()).not.toBeUndefined();
     });
 
     it("Can start a new session in case there is other apps' stale session", async () => {
@@ -161,6 +161,72 @@ describe('Session service', () => {
     });
   });
 
+  it('Can continue previous session from another app', async () => {
+    sessionService.start();
+    const sessionId = sessionService.getSessionId();
+
+    sessionService.clear();
+    currentAppId$.next('change');
+    sessionService.continue(sessionId!);
+
+    expect(sessionService.getSessionId()).toBe(sessionId);
+  });
+
+  it('Calling clear() more than once still allows previous session from another app to continue', async () => {
+    sessionService.start();
+    const sessionId = sessionService.getSessionId();
+
+    sessionService.clear();
+    sessionService.clear();
+
+    currentAppId$.next('change');
+    sessionService.continue(sessionId!);
+
+    expect(sessionService.getSessionId()).toBe(sessionId);
+  });
+
+  it('Continue drops storage configuration', () => {
+    sessionService.start();
+    const sessionId = sessionService.getSessionId();
+
+    sessionService.enableStorage({
+      getName: async () => 'Name',
+      getUrlGeneratorData: async () => ({
+        urlGeneratorId: 'id',
+        initialState: {},
+        restoreState: {},
+      }),
+    });
+
+    expect(sessionService.isSessionStorageReady()).toBe(true);
+
+    sessionService.clear();
+
+    sessionService.continue(sessionId!);
+
+    expect(sessionService.isSessionStorageReady()).toBe(false);
+  });
+
+  // it might be that search requests finish after the session is cleared and before it was continued,
+  // to avoid "infinite loading" state after we continue the session we have to drop pending searches
+  it('Continue drops client side loading state', async () => {
+    const sessionId = sessionService.start();
+
+    sessionService.trackSearch({ abort: () => {} });
+    expect(state$.getValue()).toBe(SearchSessionState.Loading);
+
+    sessionService.clear(); // even allow to call clear multiple times
+
+    expect(state$.getValue()).toBe(SearchSessionState.None);
+
+    sessionService.continue(sessionId!);
+    expect(sessionService.getSessionId()).toBe(sessionId);
+
+    // the original search was never `untracked`,
+    // but we still consider this a completed session until new search fire
+    expect(state$.getValue()).toBe(SearchSessionState.Completed);
+  });
+
   test('getSearchOptions infers isRestore & isStored from state', async () => {
     const sessionId = sessionService.start();
     const someOtherId = 'some-other-id';