[Console] Fix flaky tests and unskip the ones that now work (#193237)

elastic · Sep 18, 2024 · 7549c11 · 7549c11
1 parent 6b2bdf9
commit 7549c11
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 19 deletions.
diff --git a/test/functional/apps/console/_autocomplete.ts b/test/functional/apps/console/_autocomplete.ts
@@ -62,8 +62,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       expect(PageObjects.console.isAutocompleteVisible()).to.be.eql(true);
     });
 
-    // FLAKY: https://github.com/elastic/kibana/issues/186501
-    describe.skip('Autocomplete behavior', () => {
+    describe('Autocomplete behavior', () => {
       beforeEach(async () => {
         await PageObjects.console.clearEditorText();
       });
@@ -86,11 +85,11 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
           expect(await PageObjects.console.isAutocompleteVisible()).to.be.eql(true);
 
           for (const [i, method] of methods.entries()) {
-            expect(await PageObjects.console.getAutocompleteSuggestion(i)).to.be.eql(method);
+            expect(await PageObjects.console.getAutocompleteSuggestion(i)).to.contain(method);
           }
 
           await PageObjects.console.pressEscape();
-          await PageObjects.console.clearEditorText();
+          await PageObjects.console.clickClearInput();
         }
       });
 
@@ -354,8 +353,7 @@ GET _search
       });
     });
 
-    // FLAKY: https://github.com/elastic/kibana/issues/186935
-    describe.skip('index fields autocomplete', () => {
+    describe('index fields autocomplete', () => {
       const indexName = `index_field_test-${Date.now()}-${Math.random()}`;
 
       before(async () => {

diff --git a/test/functional/apps/console/_comments.ts b/test/functional/apps/console/_comments.ts
@@ -15,8 +15,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   const log = getService('log');
   const PageObjects = getPageObjects(['common', 'console', 'header']);
 
-  // flaky
-  describe.skip('console app', function testComments() {
+  describe('console app', function testComments() {
     this.tags('includeFirefox');
     before(async () => {
       log.debug('navigateTo console');

diff --git a/test/functional/apps/console/_console.ts b/test/functional/apps/console/_console.ts
@@ -53,8 +53,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       expect(await PageObjects.console.isOutputPanelEmptyStateVisible()).to.be(false);
     });
 
-    // the resizer doesn't work the same as in ace https://github.com/elastic/kibana/issues/184352
-    it.skip('should resize the editor', async () => {
+    it('should resize the editor', async () => {
       const editor = await PageObjects.console.getEditor();
       await browser.setWindowSize(1300, 1100);
       const initialSize = await editor.getSize();
@@ -149,7 +148,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         await PageObjects.console.clearEditorText();
       });
       it('it should send successful request to Kibana API', async () => {
-        const expectedResponseContains = 'default space';
+        const expectedResponseContains = '"name": "Default"';
         await PageObjects.console.enterText('GET kbn:/api/spaces/space');
         await PageObjects.console.clickPlay();
         await retry.try(async () => {
@@ -160,8 +159,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       });
     });
 
-    // Status badge is not yet implented in phase 2
-    describe.skip('with query params', () => {
+    describe('with query params', () => {
       it('should issue a successful request', async () => {
         await PageObjects.console.clearEditorText();
         await PageObjects.console.enterText('GET _cat/aliases?format=json&v=true&pretty=true');

diff --git a/test/functional/apps/console/_misc_console_behavior.ts b/test/functional/apps/console/_misc_console_behavior.ts
@@ -25,6 +25,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       await PageObjects.common.navigateToApp('console');
       // Ensure that the text area can be interacted with
       await PageObjects.console.skipTourIfExists();
+
+      await PageObjects.console.openConfig();
+      await PageObjects.console.toggleKeyboardShortcuts(true);
+      await PageObjects.console.openConsole();
     });
 
     beforeEach(async () => {
@@ -131,25 +135,27 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       });
     });
 
-    // Settings not yet implemented
-    it.skip('can toggle keyboard shortcuts', async () => {
+    it('can toggle keyboard shortcuts', async () => {
       // Enter a sample command
       await PageObjects.console.enterText('GET _search');
 
       // Disable keyboard shorcuts
+      await PageObjects.console.openConfig();
       await PageObjects.console.toggleKeyboardShortcuts(false);
+      await PageObjects.console.openConsole();
 
       // Upon clicking ctrl enter a newline character should be added to the editor
       await PageObjects.console.pressCtrlEnter();
       // Shortcut shouldn't have generated any request so output panel should still be in empty state
       expect(await PageObjects.console.isOutputPanelEmptyStateVisible()).to.be(true);
 
       // Restore setting
+      await PageObjects.console.openConfig();
       await PageObjects.console.toggleKeyboardShortcuts(true);
+      await PageObjects.console.openConsole();
     });
 
     describe('customizable font size', () => {
-      // flaky
       it('should allow the font size to be customized', async () => {
         await PageObjects.console.openConfig();
         await PageObjects.console.setFontSizeSetting(20);

diff --git a/test/functional/apps/console/_variables.ts b/test/functional/apps/console/_variables.ts
@@ -65,10 +65,12 @@ export default ({ getService, getPageObjects }: FtrProviderContext) => {
       });
     });
 
-    describe.skip('with variables in request body', () => {
-      // bug in monaco https://github.com/elastic/kibana/issues/185999
-      it.skip('should send a successful request', async () => {
+    describe('with variables in request body', () => {
+      it('should send a successful request', async () => {
+        await PageObjects.console.openConfig();
         await PageObjects.console.addNewVariable({ name: 'query1', value: '{"match_all": {}}' });
+        await PageObjects.console.openConsole();
+        await PageObjects.console.clickClearInput();
         await PageObjects.console.enterText('\n GET _search\n');
         await PageObjects.console.enterText(`{\n\t"query": "\${query1}"`);
         await PageObjects.console.clickPlay();